| Summary: | memcheck/tests/x86-linux/scalar fails running in Docker | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Paul Floyd <pjfloyd> |
| Component: | memcheck | Assignee: | Paul Floyd <pjfloyd> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | sam |
| Priority: | NOR | ||
| Version First Reported In: | 3.24 GIT | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Other | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Paul Floyd
2024-05-15 12:37:29 UTC
Out by one, it was 'nice' not 'ftime'. This patch works form me
--- a/memcheck/tests/x86-linux/scalar.c
+++ b/memcheck/tests/x86-linux/scalar.c
@@ -32,6 +32,11 @@ int main(void)
long x0 = px[0];
long res;
+ int in_docker = 0;
+ if (access("/.dockerenv", F_OK) == 0) {
+ in_docker = 1;
+ }
+
// All __NR_xxx numbers are taken from x86
// __NR_restart_syscall 0 // XXX: not yet handled, perhaps should be...
@@ -190,7 +195,12 @@ int main(void)
// __NR_nice 34
GO(__NR_nice, "1s 0m");
- SY(__NR_nice, x0); SUCC;
+ SY(__NR_nice, x0);
+ if (in_docker) {
+ FAIL;
+ } else {
+ SUCC;
+ }
// __NR_ftime 35
GO(__NR_ftime, "ni");
(also need to update the expected).
On second thoughts, just SUCC_OR_FAIL would be easier, but test a bit less. Doesn't seem to have fixed the nightly failures, plus this added a stupid typo causing a few failures. commit 4ccb893e7b35e63060e717aa34dc51aecb73b9f2 Author: Paul Floyd <pjfloyd@wanadoo.fr> Date: Sat Oct 25 17:56:50 2025 +0200 Bug 487055 - memcheck/tests/x86-linux/scalar fails running in Docker Also move to 3.27.0.GIT. Will this fix some of the failures in the nightly tests? |