Bug 487026

Summary:	Use symbolic icons for systray app if present
Product:	[Plasma] plasmashell	Reporter:	Christian (Fuchs) <kde>
Component:	XembedSNIProxy	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	4wy78uwh, kde, materka, nate, notmart
Priority:	NOR
Version:	6.0.4
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/-/commit/fe5794a038e4bcf719e4fa243f1f337521b04727	Version Fixed In:
Sentry Crash Report:

Description Christian (Fuchs) 2024-05-14 16:27:23 UTC

SUMMARY
As per a discussion in the VDG group: 
I propose adding either an option  (or, as per Nate, just a new default) of using the -symbolic icon for an app, if present.

Usecase: have icon themes / apps that want to support it by shipping a -symbolic icon to follow our usually monochrome icons in systray.

Logic would basically be: when loading an icon, check if there is a -symbolic suffixed version of that icon for that size, if yes: use that, if no: use the requested icon.

Argument against hardcoding it: would override apps explicit wishes.
Argument against an option: it's an option, and it might not always work, thus give users wrong expectations if not clearly worded  (e.g. should be [ ] use monochrome icon if available, not [ ] use monochrome icon)

Comment 1 Nate Graham 2024-08-06 21:07:33 UTC

This makes sense, we should just do it. It's harmless since if no such icon exists, it will fall back to simpler names until it finds something that does exist.

Comment 2 David Edmundson 2024-10-16 21:41:43 UTC

We don't have control of the drawing with xembedsniproxy.

Comment 3 Nate Graham 2024-10-16 21:58:49 UTC

We don't have control over the pixmap drawing, but we can append "-symbolic" to the icon name that it gets, for apps that send an icon name instead of or in addition to a pixmap. I interpreted this bug report to be requesting that.

Comment 4 Bug Janitor Service 2024-10-24 10:05:54 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4865

Comment 5 Marco Martin 2024-10-24 10:08:43 UTC

made a mr for it.

if an application really, really wants to use a custom drawn icon with the system not changing it, it can always send only a pixmap and not an icon name, which seems the case for instance of Telegram unless one specifically checks for "use monochrome icons" in the telegram settings

Comment 6 Bug Janitor Service 2024-10-29 09:00:06 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4878

Comment 7 Marco Martin 2024-10-29 09:42:04 UTC

Git commit fe5794a038e4bcf719e4fa243f1f337521b04727 by Marco Martin.
Committed on 29/10/2024 at 09:42.
Pushed by mart into branch 'master'.

applets/systemtray: Prefer -symbolic icons

append -symbolic to icon names in the custom icon loading mechanism in
the systemtray

This won't adress XEmbed-sniproxy icons and won't address also icons that only send a pixmap instead of an icon name, but those are cases we can't do anything about

alternative to https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4865

M  +4    -1    applets/systemtray/statusnotifieritemsource.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/fe5794a038e4bcf719e4fa243f1f337521b04727