Summary: | Dolphin takes ≥5s to load ≈ 52 GiB, 7x10^3-file directory when group column is shown | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Roke Julian Lockhart Beedell <4wy78uwh> |
Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | kfm-devel, meven29 |
Priority: | NOR | Keywords: | regression |
Version: | 24.02.2 | Flags: | 4wy78uwh:
performance+
|
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
URL: | https://discuss.kde.org/t/dolphin-struggles-to-load-directories-contain-many-files/15450/6?u=rokejulianlockhart | ||
Latest Commit: | https://invent.kde.org/frameworks/kio/-/commit/a360462d5290200b27d874d1cb3895336942d55b | Version Fixed In: | |
Sentry Crash Report: | |||
Attachments: |
Depiction of the problem.
`.perfParser` file from Hotspot. View Display Style Preferences Flamegraph |
Description
Roke Julian Lockhart Beedell
2024-05-13 12:52:58 UTC
The `perf.data` file is available at https://wim.nl.tab.digital/s/B5Ptt4qN2CdtYNP (In reply to Roke Julian Lockhart Beedell from comment #1) Redacted due to uselessness, per https://discuss.kde.org/t/dolphin-struggles-to-load-directories-which-contain-many-files/15450/8?u=rokejulianlockhart (In reply to Roke Julian Lockhart Beedell from comment #2) Flamegraph is available at https://discuss.kde.org/t/dolphin-struggles-to-load-directories-which-contain-many-files/15450/12?u=rokejulianlockhart. If I can export a proper flamegraph, I'll attach it to this bug. Created attachment 169448 [details]
`.perfParser` file from Hotspot.
This allows me to retroactively view the performance data, so it might work for you, too.
The flamegraph showed the process spend way too much time retrieve group name for the files. This is a regression from: https://invent.kde.org/frameworks/kio/-/merge_requests/1276 b1a0a7cfe704db2a0aa363fed4e03501f324df9e This is easily reproducible in dolphin, simply show the user group column with a moderate to high number of files. Created attachment 169449 [details] View Display Style Preferences (In reply to Méven Car from comment #6) (In reply to Roke Julian Lockhart Beedell from comment #7) Indeed, disabling that fixes it for me. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/1630 Git commit a360462d5290200b27d874d1cb3895336942d55b by Méven Car. Committed on 15/05/2024 at 06:05. Pushed by meven into branch 'master'. kfileitem: cache group names Since b1a0a7cfe704db2a0aa363fed4e03501f324df9e the group name is now fetch in KFFileItem, it was previously fetched inside the file kioworker. Cache the group names in KFileItem using a thread local QMap. M +9 -1 src/core/kfileitem.cpp https://invent.kde.org/frameworks/kio/-/commit/a360462d5290200b27d874d1cb3895336942d55b |