| Summary: | Error transferring https://social.opendesktop.org/api/v1/push/subscription - server replied: . Please check your settings. | ||
|---|---|---|---|
| Product: | [Applications] Tokodon | Reporter: | Justin Zobel <justin> |
| Component: | general | Assignee: | Unassigned bugs mailing-list <unassigned-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | carl, josh |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/network/tokodon/-/commit/1cc98dbf3f94467e1ff445d16e0dde473a13687a | Version Fixed In: | 24.08 |
| Sentry Crash Report: | |||
|
Description
Justin Zobel
2024-05-09 23:35:32 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/tokodon/-/merge_requests/517 Yes this is a harmless error but we really shouldn't print it as it's normal to get a 404 there. This goes for a whole lot of other cases as well, so let's axe the log notification when we handle it explicitly. Git commit 1cc98dbf3f94467e1ff445d16e0dde473a13687a by Joshua Goins. Committed on 06/07/2024 at 16:28. Pushed by redstrate into branch 'master'. Only print out HTTP warnings for errors we don't explicitly handle So when we make HTTP requests, by default we don't handle errors. Doing so requires setting another callback to handle errors specifically. We also print out a warning saying a URL 404'd and such so users can report server errors we maybe should or shouldn't handle. In some cases this backfires, causing errors to be printed out even if we handle those error cases specifically. A good example is unified push support, where we prod the server (who will return a 404 if we don't have permissions) and this clogs up the logs. Now we consider any explicit error callback to be considered handled and no longer print an error in the log. M +1 -1 src/account/account.cpp https://invent.kde.org/network/tokodon/-/commit/1cc98dbf3f94467e1ff445d16e0dde473a13687a |