Bug 486768

Summary: [git master] - Open app in Icon Only Task manager use more space than closed app.
Product: [Plasma] plasmashell Reporter: dmatteo002
Component: Task Manager and Icons-Only Task Manager widgetsAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: dmatteo002, jan.rathmann, nate, qydwhotmail
Priority: NOR Keywords: qt6, regression
Version First Reported In: masterFlags: dmatteo002: Wayland+
dmatteo002: X11+
Target Milestone: 1.0   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Video of change in size (while changing virtual desktop)
Video of secondary issue (0 sized for a frame or so)

Description dmatteo002 2024-05-08 07:54:44 UTC
Created attachment 169298 [details]
Video of change in size (while changing virtual desktop)

SUMMARY
In Icon task manager, icon of not opened app are smaller than when opened 


STEPS TO REPRODUCE
1. Have a panel with icon only task manager
2. Open one of the app

OBSERVED RESULT
The space used by the app icon (plus padding) is increased moving other app. 

EXPECTED RESULT
The icon size (plus padding) should not change in size.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 6.0.80
KDE Frameworks Version: 6.2.0
Qt Version: 6.7.0
Kernel Version: 6.8.9-arch1-1 (64-bit)
Graphics Platform: Wayland
Graphics Processor: AMD Radeon Graphics
Comment 1 Nate Graham 2024-05-12 02:56:19 UTC
Can reproduce with certain amounts of space for the task manager widget. Introduced with https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2239.
Comment 2 Bug Janitor Service 2024-05-12 14:29:50 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2246
Comment 3 dmatteo002 2024-05-12 17:25:08 UTC
I tested the open merge request and it indeed fix the issue.

I still have an issue with icon size while switching virtual desktop or while opening app, not sure if it is relevant. I'll add a video of the other issue as an attachments. What happen is when app change state from closed to open in the task manager, it sometimes get a size of zero (i think) for just a frame or so and then revert to default sizing.

If it isn't relevant I'll open another bug report for it.
Comment 4 dmatteo002 2024-05-12 17:27:03 UTC
Created attachment 169400 [details]
Video of secondary issue (0 sized for a frame or so)
Comment 5 Bharadwaj Raju 2024-05-13 08:32:09 UTC
Git commit 6a0d822c6aea8944fec31bd38813fba1fe4fb7d5 by Bharadwaj Raju.
Committed on 13/05/2024 at 08:25.
Pushed by bharadwaj-raju into branch 'master'.

applets/taskmanager: Fix launcher icon widths when in icons-only mode

Commit d1b33d1a9dc872e9a2af042152d6ab5ed2617e4e introduced logic to use
height / num_rows as the width for launcher-type (no open windows) icons. This
makes sense for Icons-and-Text TM, but leads to incorrect widths in the
Icons-only TM.

M  +1    -1    applets/taskmanager/package/contents/ui/Task.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/6a0d822c6aea8944fec31bd38813fba1fe4fb7d5