Bug 486703

Summary:	Delete Panel button is right where people instinctively hit OK. Propose Manage Panels screen.
Product:	[Plasma] plasmashell	Reporter:	myusualnickname <myusualnickname>
Component:	Panel	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate, niccolo.venerandi
Priority:	NOR
Version First Reported In:	6.0.4
Target Milestone:	1.0
Platform:	Other
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=483299
Latest Commit:	https://invent.kde.org/plasma/plasma-desktop/-/commit/52d352fb32abd876fdfd51fd5c9ed28ce73b0442	Version Fixed/Implemented In:	6.1
Sentry Crash Report:

Description myusualnickname@gmail.com 2024-05-07 06:35:58 UTC

When editing a panel in testing Neon

qt 6.7, frameworks 6.2

The delete panel button is in a very easy to accidentally hit spot.

There is an undo option that pops up, but I think a popup confirming it makes more sense if it cannot be moved...

and it makes sense to ask, are you sure even if it was a better spot.

Perhaps it would be better to have a panel management button instead of delete panel,  and then have a list of panels, and be able to activate or deactivate them from that list, or clone them, or import and export them, and clone them, and also delete from that other menu.

This way a person can turn off a panel and bring it back without relying on an undo mechanism.

Comment 1 Nate Graham 2024-05-07 20:30:42 UTC

Yes, this is awkward. It'll be fixed by https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2021

Comment 2 Bug Janitor Service 2024-05-07 22:40:13 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2240

Comment 3 Nate Graham 2024-05-10 00:42:57 UTC

Git commit 52d352fb32abd876fdfd51fd5c9ed28ce73b0442 by Nate Graham.
Committed on 10/05/2024 at 00:42.
Pushed by ngraham into branch 'master'.

PanelConfiguration: make it more obvious how you close it

Right now, there's no clear way to close the panel configuration dialog.
It lacks both an OK or Done button like you'd see in a dialog, and also
a close button in the fake titlebar like you'd see in a real window.
The dialog also doesn't disappear on focus loss like the old UI did.

This isn't ideal. Let's address it by adding a "Done" button to the
bottom-trailing position, where people generally expect to see buttons
to close dialogs.

I chose this over a close button in the fake titlebar because a close
button (especially a red one, as the Breeze icon is) might be seen more
negatively, i.e. "throw away settings". Whereas a "Done" button with
a checkmark is clearly an affirmative action that will accept and save
any changed settings.

To make room, the Delete Panel button is moved to the other side of the
footer, and the shortcut UI is added into the body of the dialog, where
the thickness control lives.

---

Thanks to @eatsu for starting this off in https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2021.

This is an intentionally minimal change to fix a targeted UX issue; let's try to avoid redesigning the entire dialog or else we'll go in circles like we did there.

Co-authored-by: Taro Tanaka <mkrmdk@gmail.com>
Related: bug 483299
FIXED-IN: 6.1

@teams/vdg @teams/usability

| Before | After |
| ------ | ----- |
| ![Before](/uploads/e74e84963544a4d4a5e35ed4245ed951/Before.jpeg) | ![After](/uploads/17e217a34b5ff5809491764afcb5ef32/After.jpeg) |

M +43 -26 desktoppackage/contents/configuration/PanelConfiguration.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/52d352fb32abd876fdfd51fd5c9ed28ce73b0442