Bug 486465

Summary: turning off spell checking in the compose window doesn't persist after posting
Product: [Applications] Tokodon Reporter: Charlotte <charlotte>
Component: generalAssignee: Unassigned bugs mailing-list <unassigned-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: carl, josh
Priority: NOR    
Version: 24.02.2   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: https://invent.kde.org/network/tokodon/-/commit/86903e9d4551d58eb5233bda03297f5130397255 Version Fixed In: 24.05
Sentry Crash Report:

Description Charlotte 2024-05-02 17:24:32 UTC 
***
If you're not sure this is actually a bug, instead post about it at https://discuss.kde.org

If you're reporting a crash, attach a backtrace with debug symbols; see https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***

SUMMARY


STEPS TO REPRODUCE
1. open post compose window
2. right-click and uncheck "spell check"
3. post 'toot'
4. 

OBSERVED RESULT
open compose again; "spell check" is re-checked

EXPECTED RESULT
open compose again; "spell check" remains turned off

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: openSuse Tumbleweed (wayland)

(available in About System)
KDE Plasma Version: 6.0.4
KDE Frameworks Version: 6.1.0
Qt Version: 6.7.0

ADDITIONAL INFORMATION
chatted with "redstrate" on Matrix on 2024-05-02
Comment 1 Joshua Goins 2024-05-11 15:35:25 UTC 
Git commit a17b7a62406f59f0c9904de95b84a1c4e48b7794 by Joshua Goins.
Committed on 11/05/2024 at 15:35.
Pushed by redstrate into branch 'master'.

Don't enforce the spellchecker even when it's disabled

qqc2-desktop-style already handles this for us by checking if Sonnet is
disabled and enabling the spell check if needed.

M  +0    -1    src/content/ui/StatusComposer/StatusComposer.qml

https://invent.kde.org/network/tokodon/-/commit/a17b7a62406f59f0c9904de95b84a1c4e48b7794
Comment 2 Joshua Goins 2024-05-11 15:35:46 UTC 
Git commit 86903e9d4551d58eb5233bda03297f5130397255 by Joshua Goins.
Committed on 11/05/2024 at 15:35.
Pushed by redstrate into branch 'release/24.05'.

Don't enforce the spellchecker even when it's disabled

qqc2-desktop-style already handles this for us by checking if Sonnet is
disabled and enabling the spell check if needed.
(cherry picked from commit a17b7a62406f59f0c9904de95b84a1c4e48b7794)

M  +0    -1    src/content/ui/StatusComposer/StatusComposer.qml

https://invent.kde.org/network/tokodon/-/commit/86903e9d4551d58eb5233bda03297f5130397255
Comment 3 Joshua Goins 2024-05-11 15:37:53 UTC 
This is partially on us, we were enforcing the spell checker always. The settings are a little bit confusing right now, but this is a greater Kirigami/Sonnet issue. Now:

- If you want to disable spell checking by default, uncheck the "Automatic spell-checking" under Settings.
- If you want to enable or disable spell checking temporarily, use the right-click or long-tap context menu.
- Note that the global setting takes a restart of Tokodon to take effect.