| Summary: | System Settings allows users to select Adwaita as an icon theme, which breaks things due to missing icons | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Neal Gompa <ngompa13> |
| Component: | kcm_icons | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | 4wy78uwh, kde, nate, timaeos |
| Priority: | NOR | ||
| Version: | 6.0.4 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| See Also: | https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/issues/288 | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/c8b8a4db63b575edf931c3d61aea1ed3d3d287f2 | Version Fixed In: | 6.0.5 |
| Sentry Crash Report: | |||
|
Description
Neal Gompa
2024-05-01 16:07:20 UTC
Given the problems described in https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/issues/288, I think this is reasonable until Adwaita regains the ability to be a proper FDO-compatible icon theme. We should also probably block the GNOME/GTK built-in high contrast theme too for the same reason. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4280 Git commit 813d22ff80ede0c7c08e4563621e3778459426f0 by Nate Graham. Committed on 01/05/2024 at 21:24. Pushed by ngraham into branch 'master'. kcms/icons: filter out GNOME's Adwaita and High Contrast icon themes These are no longer FDO-compatible icon themes, and are apparently no longer intended to be used for non-GNOME apps--going against what an FDO icon theme is supposed to be used for. I've contacted the GNOME folks about it, and unfortunately they've made it clear that the situation is intended; see https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/issues/288 As such, allowing the user to select these icon themes will just give them an opportunity to break all their non-GNOME apps. Let's filter these themes out to prevent that possibility. We still need to figure out a solution for when our apps are run in distros where Adwaita is used as the default icon theme, but that's a separate topic. FIXED-IN: 6.1 M +12 -0 kcms/icons/iconsmodel.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/813d22ff80ede0c7c08e4563621e3778459426f0 Git commit c8b8a4db63b575edf931c3d61aea1ed3d3d287f2 by Nate Graham. Committed on 01/05/2024 at 21:50. Pushed by ngraham into branch 'Plasma/6.0'. kcms/icons: filter out GNOME's Adwaita and High Contrast icon themes These are no longer FDO-compatible icon themes, and are apparently no longer intended to be used for non-GNOME apps--going against what an FDO icon theme is supposed to be used for. I've contacted the GNOME folks about it, and unfortunately they've made it clear that the situation is intended; see https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/issues/288 As such, allowing the user to select these icon themes will just give them an opportunity to break all their non-GNOME apps. Let's filter these themes out to prevent that possibility. We still need to figure out a solution for when our apps are run in distros where Adwaita is used as the default icon theme, but that's a separate topic. FIXED-IN: 6.0.5 (cherry picked from commit 813d22ff80ede0c7c08e4563621e3778459426f0) M +12 -0 kcms/icons/iconsmodel.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/c8b8a4db63b575edf931c3d61aea1ed3d3d287f2 |