| Summary: | "Power and Battery" Widget icon does not update when changed via `powerprofilesctl` | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Kye <kyliepc> |
| Component: | Power and Battery widget | Assignee: | Natalie Clarius <natalie_clarius> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | kde, me, natalie_clarius, nate, whyhow+tech |
| Priority: | NOR | ||
| Version: | 6.0.3 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/67b7f3b6fbe640b0c476b5b6a2e1e8f387a8f426 | Version Fixed In: | 6.1 |
| Sentry Crash Report: | |||
|
Description
Kye
2024-04-15 20:04:29 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/powerdevil/-/merge_requests/349 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4240 Random additional thought but it'd be nice if along with this there's a pop-up indicating the power profile like with brightness, volume or touch pad changes (In reply to Kye from comment #3) > Random additional thought but it'd be nice if along with this there's a > pop-up indicating the power profile like with brightness, volume or touch > pad changes The pattern we have adopted here is that we show an OSD when there is no other visual confirmation that tge change took effect, eg when using keyboard shortcuts or scrolling on the applet. When you use powerprofilesctl, you would see that the command completed in the terminal so showing an additional pop-up would seem unnecessarily distracting. (In reply to Natalie Clarius from comment #4) > The pattern we have adopted here is that we show an OSD when there is no > other visual confirmation that tge change took effect, eg when using > keyboard shortcuts or scrolling on the applet. When you use > powerprofilesctl, you would see that the command completed in the terminal > so showing an additional pop-up would seem unnecessarily distracting. My idea here was if I change it via my laptop keybind. (In reply to Kye from comment #5) > (In reply to Natalie Clarius from comment #4) > > The pattern we have adopted here is that we show an OSD when there is no > > other visual confirmation that tge change took effect, eg when using > > keyboard shortcuts or scrolling on the applet. When you use > > powerprofilesctl, you would see that the command completed in the terminal > > so showing an additional pop-up would seem unnecessarily distracting. > My idea here was if I change it via my laptop keybind. So you have a shortcut to switch to a power profile using powerprofilesctl set? Fyi, there is a built-in feature to cycle profiles assigned to Meta+B by default. (In reply to Natalie Clarius from comment #6) > So you have a shortcut to switch to a power profile using powerprofilesctl > set? Fyi, there is a built-in feature to cycle profiles assigned to Meta+B > by default. My laptop has a built-in power profile cycle button (TUF a15). I'll use the built-in profile switcher, thanks for telling me about that! Git commit 4614e7c4e46cfbc46323c4b5c902e983ca19a237 by Nicolas Fella, on behalf of Natalie Clarius. Committed on 01/05/2024 at 12:05. Pushed by nclarius into branch 'master'. actions/powerprofile: expose configured profile in DBus interface So the applet can determine whether to show an icon indicating the current profile when it is not the default one. M +6 -0 daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.PowerProfile.xml M +6 -0 daemon/actions/bundled/powerprofile.cpp M +3 -0 daemon/actions/bundled/powerprofile.h https://invent.kde.org/plasma/powerdevil/-/commit/4614e7c4e46cfbc46323c4b5c902e983ca19a237 Git commit 67b7f3b6fbe640b0c476b5b6a2e1e8f387a8f426 by Natalie Clarius. Committed on 01/05/2024 at 22:33. Pushed by nclarius into branch 'master'. applets/battery: consistently indicate when in non-default power profile - fix current profile indicator out of sync betweeen multiple applet instances - indicate when power profile was manually changed from outside the applet, eg powerprofilesctl - indicate when power profile was manually set to balanced if this is not the default for the current power state - don't indicate profile holds if the profile is the default for the current power state anyway where indicate = show the applet as relevant, and use a special icon for the compact representation. M +24 -17 applets/batterymonitor/package/contents/ui/CompactRepresentation.qml M +10 -11 applets/batterymonitor/package/contents/ui/main.qml M +26 -12 applets/batterymonitor/plugin/powerprofilescontrol.cpp M +5 -18 applets/batterymonitor/plugin/powerprofilescontrol.h M +17 -0 dataengines/powermanagement/powermanagementengine.cpp M +1 -0 dataengines/powermanagement/powermanagementengine.h https://invent.kde.org/plasma/plasma-workspace/-/commit/67b7f3b6fbe640b0c476b5b6a2e1e8f387a8f426 |