| Summary: | Invoking and dismissing the "Toolbar settings" context menu causes reproducible crash. | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kxmlgui | Reporter: | Roke Julian Lockhart Beedell <4wy78uwh> |
| Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | alex.bikadorov |
| Priority: | NOR | Flags: | 4wy78uwh:
performance-
|
| Version First Reported In: | 6.3.0 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| URL: | https://bugzilla.redhat.com/show_bug.cgi?id=2275016#c0:~:text=description%20of%20problem%3A%201.%20%22edit%20bookmarks%22%202.%20invoke%20the%20%22toolbar%20settings%22%20context%20menu.%203.%20close%20the%20context%20menu.%20it%20reproducibly%20crashes | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=499505 https://bugzilla.redhat.com/show_bug.cgi?id=2349038 https://bugzilla.redhat.com/show_bug.cgi?id=2275016 |
||
| Latest Commit: | Version Fixed In: | 6.4.4 | |
| Sentry Crash Report: | |||
|
Description
Roke Julian Lockhart Beedell
2024-04-14 21:03:35 UTC
I can reproduce this in keditbookmarks and in experimental KF6 branch of Krusader: > #0 0x0000155553510434 in QAction::associatedObjects() const () from /usr/lib/libQt6Gui.so.6 > #1 0x000015555534fff4 in KToolBar::contextMenuEvent(QContextMenuEvent*) () from /usr/lib/libKF6XmlGui.so.6 > #2 0x0000155553b4c322 in QWidget::event(QEvent*) () from /usr/lib/libQt6Widgets.so.6 > #3 0x0000155553afc55c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/libQt6Widgets.so.6 > #4 0x0000155553b02f1b in QApplication::notify(QObject*, QEvent*) () from /usr/lib/libQt6Widgets.so.6 > #5 0x0000155552b44e38 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /usr/lib/libQt6Core.so.6 > #6 0x0000155553b62175 in ?? () from /usr/lib/libQt6Widgets.so.6 > #7 0x0000155553b636b0 in ?? () from /usr/lib/libQt6Widgets.so.6 > #8 0x0000155553afc55c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/libQt6Widgets.so.6 > #9 0x0000155552b44e38 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /usr/lib/libQt6Core.so.6 > #10 0x0000155553176cf0 in QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) () from /usr/lib/libQt6Gui.so.6 > #11 0x00001555531e5b44 in QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt6Gui.so.6 > #12 0x00001555535f9594 in ?? () from /usr/lib/libQt6Gui.so.6 > #13 0x0000155550473a89 in ?? () from /usr/lib/libglib-2.0.so.0 > #14 0x00001555504d59b7 in ?? () from /usr/lib/libglib-2.0.so.0 > #15 0x0000155550472f95 in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0 > #16 0x0000155552da28dd in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt6Core.so.6 > #17 0x0000155552b4f10e in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt6Core.so.6 > #18 0x0000155552b4945d in QCoreApplication::exec() () from /usr/lib/libQt6Core.so.6 > #19 0x000055555562dbc1 in main (argc=2, argv=0x7fffffffe038) at {...}/krusader/app/main.cpp:314 > #20 0x0000155552439c88 in ?? () from /usr/lib/libc.so.6 > #21 0x0000155552439d4c in __libc_start_main () from /usr/lib/libc.so.6 > #22 0x00005555555faa75 in _start () All actions in the context menu (e.g. "Lock Toolbar Positions") lead to crash. However, I could fix it in Krusader by replacing >setXMLFile("krusaderui.rc"); >createGUI(...); with >setupGUI(Default, "krusaderui.rc"); and I noticed that setupGUI() must be called with the "ToolBar" flag, otherwise the very same bug occurs again. In keditbookmarks >void KXmlGuiWindow::createGUI(const QString& xmlfile) is used and I assume that replacing it by > setupGUI(Defaults, ...) would fix it here as well. Because the docs say that the "ToolBar" flag is not mandatory (and that createGUI() could also be used) I'm moving this to KXMLGui. KDE Frameworks 6.3.0 Qt 6.7.1 *** Bug 498433 has been marked as a duplicate of this bug. *** *** Bug 499071 has been marked as a duplicate of this bug. *** (In reply to Alex Bikadorov from comment #1) Thanks for the much better analysis than I provided. > I can reproduce this in keditbookmarks, and in experimental KF6 branch of Krusader. What did you do to reproduce it in Krusader? Did you just access KEditBookmarks via one of the one of the KDolphinPart-equivalents' toolbars, or does doing something in Krusader's GUI work, too? > Because the docs say that the "ToolBar" flag is not mandatory (and that createGUI() could also be used) I'm moving this to KXMLGui. I'll set it as CONFIRMED, too. Its counterpart is, as of today. >What did you do to reproduce it in Krusader? Did you just access KEditBookmarks via one of the one of the KDolphinPart-equivalents' toolbars, or does doing something in Krusader's GUI work, too? I really meant Krusader itself. After it was ported to KF6 it crashed when any GUI action in the context menu of the toolbar is clicked. The fix was basically this line: https://invent.kde.org/utilities/krusader/-/blob/master/app/krusader.cpp?ref_type=heads#L198 (commit 4a0d063a3c3d05f57 in the Krusader repo). (In reply to Roke Julian Lockhart Beedell from comment #0) This also affects `KFontView`, per https://bugzilla.redhat.com/show_bug.cgi?id=2349038#c0. (In reply to Roke Julian Lockhart Beedell from comment #6) This appears to be resolved in plasma-workspace-6.4.4-1.fc42.x86_64. Dunno which commit, though. *** Bug 498434 has been marked as a duplicate of this bug. *** |