Bug 485408

Summary: 4ad6a5d8bc0a60c14e7d76d148c1c3db786db706 loses Ctrl+Q quit action and window size/position memory
Product: [Applications] systemsettings Reporter: Nate Graham <nate>
Component: generalAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: nicolas.fella
Priority: NOR Keywords: regression
Version First Reported In: master   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Nate Graham 2024-04-12 01:50:31 UTC 
commit 4ad6a5d8bc0a60c14e7d76d148c1c3db786db706
Author: Nicolas Fella <nicolas.fella@gmx.de>
Date:   Sun Apr 7 00:04:48 2024 +0200

    Port away from KXmlGuiWindow
    
    Systemsettings is not a traditional KXmlGui app
    
    It doesn't provide us with much


Well some of the things it does provide are:
- a Quit action that triggers on Ctrl+Q
- window size/position memory

And those are now lost.
Comment 1 Nicolas Fella 2024-04-12 10:17:29 UTC 
The quit action is still there: https://invent.kde.org/plasma/systemsettings/-/blob/master/app/SettingsBase.cpp?ref_type=heads#L124

There is indeed a problem with shortcuts for the actions.

Size/position is done by KMainWindow, which is still used, so it _should_ work
Comment 2 Bug Janitor Service 2024-04-12 10:26:46 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/310
Comment 3 Bug Janitor Service 2024-04-12 10:38:25 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/311
Comment 4 Nicolas Fella 2024-04-12 10:45:27 UTC 
Git commit dc730a7e504b3fdeeaf5261c32934e2bd07b4de2 by Nicolas Fella.
Committed on 12/04/2024 at 10:38.
Pushed by nicolasfella into branch 'master'.

Associate window with actioncollection

This is needed for the action shortcuts to work

This was done implicitly by KXmlGuiWindow before

M  +2    -0    app/SettingsBase.cpp

https://invent.kde.org/plasma/systemsettings/-/commit/dc730a7e504b3fdeeaf5261c32934e2bd07b4de2
Comment 5 Nicolas Fella 2024-04-12 10:46:30 UTC 
Git commit 185aa54a73a182cbe4692402c3fbd1dbb97764c0 by Nicolas Fella.
Committed on 12/04/2024 at 10:45.
Pushed by nicolasfella into branch 'master'.

Enable saving window state

KXmlGuiWindow did that automatically, with KMainWindow we need to opt into it

M  +2    -0    app/SettingsBase.cpp

https://invent.kde.org/plasma/systemsettings/-/commit/185aa54a73a182cbe4692402c3fbd1dbb97764c0
Comment 6 Nate Graham 2024-04-12 13:22:40 UTC 
Thanks!