Summary: | Modifying kxkbrc configuration through the command line does not make changes take effect immediately | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Bojidar Marinov [:bojidar-bg] <bojidar.marinov.bg> |
Component: | input | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | bojidar.marinov.bg, fanzhuyifan, nate |
Priority: | NOR | ||
Version First Reported In: | 6.0.2 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/-/commit/ead59561b7277c9d75066e6fb420e109beb40944 | Version Fixed In: | 6.5.0 |
Sentry Crash Report: |
Description
Bojidar Marinov [:bojidar-bg]
2024-04-11 08:50:01 UTC
Using KConfigWatcher would make sense here, sure. If this is something you'd be interested in working on, please feel free! A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/7655 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/3012 Git commit c75d26ff98fc40004923e4e0f9bb441c3b970ec3 by Nate Graham, on behalf of Bojidar Marinov. Committed on 03/06/2025 at 14:55. Pushed by ngraham into branch 'master'. keyboard_layout: use KConfigWatcher to listen for config changes Currently, kwin uses a bespoke `org.kde.keyboard.reloadConfig` DBus signal to reload the keyboard configuration. However, when automating keyboard layout configuration changes, this ends up harming usability a lot, requiring users to do [e.g.](https://askubuntu.com/a/1510142): ```bash kwriteconfig6 --file kxkbrc --group Layout --key LayoutList en,de dbus-send --session --type=signal --dest=org.kde.keyboard /Layouts org.kde.keyboard.reloadConfig ``` With this commit, keyboard layouts use `KConfigWatcher`, to instead allow for the much simpler: ```bash kwriteconfig6 --file kxkbrc --group Layout --key LayoutList en,de --notify ``` M +24 -24 autotests/integration/keyboard_layout_test.cpp M +1 -0 autotests/integration/kwin_wayland_test.cpp M +9 -6 src/keyboard_layout.cpp M +4 -1 src/keyboard_layout.h https://invent.kde.org/plasma/kwin/-/commit/c75d26ff98fc40004923e4e0f9bb441c3b970ec3 Git commit ead59561b7277c9d75066e6fb420e109beb40944 by Nate Graham, on behalf of Bojidar Marinov. Committed on 03/06/2025 at 14:56. Pushed by ngraham into branch 'master'. kcms/keyboard: use KConfig::Notify instead of custom DBus signals for layout config changes This is a companion commit to https://invent.kde.org/plasma/kwin/-/merge_requests/7655. It is a refactoring which drops the custom `org.kde.keyboard.reloadConfig` DBus signal, replacing it with the more standard KConfig::Notify approach. FIXED-IN: 6.5.0 M +0 -1 kcms/keyboard/CMakeLists.txt M +0 -4 kcms/keyboard/kcm_keyboard.cpp M +3 -10 kcms/keyboard/keyboard_daemon.cpp M +2 -1 kcms/keyboard/keyboard_daemon.h D +0 -11 kcms/keyboard/keyboard_dbus.h M +1 -0 kcms/keyboard/keyboardsettings.kcfgc https://invent.kde.org/plasma/plasma-desktop/-/commit/ead59561b7277c9d75066e6fb420e109beb40944 |