Bug 485350

Summary: In Spectacle, there is no way to do a text paragraph (Enter) without triggering the "Take Photo" function
Product: [Applications] Spectacle Reporter: Eduardo Correia <eduardosareias>
Component: GeneralAssignee: Noah Davis <noahadvs>
Status: RESOLVED FIXED    
Severity: normal CC: kde, nate
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 24.05
Sentry Crash Report:

Description Eduardo Correia 2024-04-10 23:04:23 UTC 
SUMMARY
When doing a selection for a screenshot and then adding text to it, if we ever need to click the Enter key to add a paragraph or just do a line break to continue adding more text in the line bellow, Spectacle just immediatly takes the screenshot (because Spectacle reads the Enter key as the "accept" key). Trying the shift + Enter shortcut does not work, it still takes the screenshot.

Suggestion: Spectacle should probably disable the "Enter to save the screenshot" shortcut while the user is currently editing text on a text box to the screenshot selection, and clicking Enter should do a line break instead. Or, another idea would be to make Enter finish the text box editing (but still stay in the selection screen), so the user could add another text box bellow it as needed, and also read the Shift + Enter universal shortcut as a line break on the current text box that is being edited.


STEPS TO REPRODUCE
1. Initiate a selection for a new screenshot with Spectacle;
2. Right in the selection, add a text box and write some text;
3. Try to do a line break/paragraph, but notice that Spectacle just finishes the screenshot even if you were just trying to add a paragraph to your text.

OBSERVED RESULT
Spectacle finishes editing and takes the screenshot right when Enter is pressed (with text being added).

EXPECTED RESULT
Being able to do line breaks/paragraphs when adding text to screenshot selections.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Noah Davis 2024-04-11 01:42:31 UTC 
What version are you on? The current supported version (24.02) seems to support multi-line text just fine.
Comment 2 Eduardo Correia 2024-04-11 10:44:04 UTC 
(In reply to Noah Davis from comment #1)
> What version are you on? The current supported version (24.02) seems to
> support multi-line text just fine.

Sorry it was late at night and I forgot to fill in the versions of plasma and applications. Plasma 6.0.3, KDE Frameworks 6.6.0. Spectacle 24.02.1 .

I just cannot do a multi line while in the screen area selection. Everytime I click enter it just finishes the selection and takes the screenshot.
After the screenshot was taken and the screenshot/spectacle window is opened, if I edit and add text I still cannot do Enter. It just won't do anything at all here. The cursor stays at the same single line. Is there a setting that affects this that I might have turned off by mistake or is this a bug?

I have no idea if this helps, but its a full AMD system on Wayland, Nobara Linux (Fedora based).
Comment 3 Noah Davis 2024-04-11 18:29:50 UTC 
It sounds like a bug, but I'm unable to reproduce it.
Comment 4 Nate Graham 2024-04-11 19:41:30 UTC 
It's working as expected for me too with current git master.
Comment 5 Eduardo Correia 2024-04-11 19:57:16 UTC 
I can always reproduce it. Both on my desktop (Nobara Linux, Plasma 6.0.3) and on my laptop (Fedora with Plasma 6.0.3 also). Both have Spectacle 24.02.1.

To end any suspicions about my configuration or my spectacle shortcuts being the problem, I restored the defaults on Spectacle settings. But it still didn't solve my problem.

I will link a video of what I am talking about, since I probably am not explaining the problem very well:
https://drive.google.com/file/d/17Mk0LaW23LmDJohlJJNh2pAP8eO5ZxQa/view

While adding text, I cannot click enter to do a paragraph or line break. It just takes the screenshot immediately. Is this a bug on my system or is the functionality actually missing from spectacle?
Comment 6 Nate Graham 2024-04-12 16:58:30 UTC 
Looks like you described it perfectly, because your screen recording shows exactly what I'm doing too and it works for me!

However I think it's only fixed in master, because I built the latest tip of the release/24.02 branch and can reproduce your issue exactly there. Marking as fixed in the next version.
Comment 7 Eduardo Correia 2024-04-12 16:59:55 UTC 
(In reply to Nate Graham from comment #6)
> Looks like you described it perfectly, because your screen recording shows
> exactly what I'm doing too and it works for me!
> 
> However I think it's only fixed in master, because I built the latest tip of
> the release/24.02 branch and can reproduce your issue exactly there. Marking
> as fixed in the next version.

Those are very great news! Thank you for all the effort :)