| Summary: | Move back and forward between folders using mouse buttons | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | zwpp <zwpp> |
| Component: | panels: folders | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | brandowlucas, gameingultra42, kfm-devel, meven29 |
| Priority: | NOR | ||
| Version: | 24.02.1 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/system/dolphin/-/commit/131c889b0c050592809035242db6200482e0edde | Version Fixed In: | 24.12 |
| Sentry Crash Report: | |||
|
Description
zwpp
2024-04-09 20:28:36 UTC
A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/807 Git commit 131c889b0c050592809035242db6200482e0edde by Méven Car. Committed on 31/07/2024 at 12:04. Pushed by meven into branch 'master'. Kitemlistcontroller: only accept doubleclick for left mouse button Add test for double-click activation. M +1 -1 src/kitemviews/kitemlistcontroller.cpp M +58 -0 src/tests/kitemlistcontrollertest.cpp https://invent.kde.org/system/dolphin/-/commit/131c889b0c050592809035242db6200482e0edde commit 131c889b does not actually fix this issue. I just built it, and the double click delay still applies to the back and forward buttons, and double clicking the back or forward buttons when the mouse cursor does not have a file or directory behind it selects all items in the current directory. Operating System: CachyOS Linux KDE Plasma Version: 6.1.3 KDE Frameworks Version: 6.4.0 Qt Version: 6.7.2 Kernel Version: 6.9.9-1-cachyos-echo-lto (64-bit) Graphics Platform: Wayland A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/810 (In reply to gameingultra42 from comment #3) > commit 131c889b does not actually fix this issue. I just built it, and the > double click delay still applies to the back and forward buttons, and double > clicking the back or forward buttons when the mouse cursor does not have a > file or directory behind it selects all items in the current directory. > I was focusing on other issue I noticed the bug title sort-of implied. > I noticed a delay when I move back and forward between folders using the mouse buttons (4-5), this delay is equal to double-clicking the left mouse button on a folder to open it. I don't notice a delay like this, I set my double-click delay to 1 second, but the forward/back mouse button are unaffected, using Dolphin Version 24.05.2. (In reply to Méven Car from comment #5) > (In reply to gameingultra42 from comment #3) > > commit 131c889b does not actually fix this issue. I just built it, and the > > double click delay still applies to the back and forward buttons, and double > > clicking the back or forward buttons when the mouse cursor does not have a > > file or directory behind it selects all items in the current directory. > > > I was focusing on other issue I noticed the bug title sort-of implied. > > > I noticed a delay when I move back and forward between folders using the mouse buttons (4-5), this delay is equal to double-clicking the left mouse button on a folder to open it. > > I don't notice a delay like this, I set my double-click delay to 1 second, > but the forward/back mouse button are unaffected, using Dolphin Version > 24.05.2. About the delay : for some reason, setting the double click delay over 400ms does not increase the back/forward delay. However, lowering it under 400ms, also lowers the back/forward delay. (In reply to gameingultra42 from comment #6) > (In reply to Méven Car from comment #5) > > (In reply to gameingultra42 from comment #3) > > > commit 131c889b does not actually fix this issue. I just built it, and the > > > double click delay still applies to the back and forward buttons, and double > > > clicking the back or forward buttons when the mouse cursor does not have a > > > file or directory behind it selects all items in the current directory. > > > > > I was focusing on other issue I noticed the bug title sort-of implied. > > > > > I noticed a delay when I move back and forward between folders using the mouse buttons (4-5), this delay is equal to double-clicking the left mouse button on a folder to open it. > > > > I don't notice a delay like this, I set my double-click delay to 1 second, > > but the forward/back mouse button are unaffected, using Dolphin Version > > 24.05.2. > > About the delay : for some reason, setting the double click delay over 400ms > does not increase the back/forward delay. However, lowering it under 400ms, > also lowers the back/forward delay. I doubt the specific buttons have something to do with this, at least I can't reproduce. I wonder if all your folders are affected, or if this is just specify drives or network folders that are concerned. Git commit 819960aed450d9aa40fd42dc42ad7119c88a4802 by Méven Car, on behalf of Wolfgang Müller. Committed on 17/10/2024 at 14:07. Pushed by meven into branch 'master'. kitemlistcontroller: process forward/back buttons when double-clicking Tapping the forward or back mouse buttons quickly enough makes Dolphin interpret the action as a double-click of the button in question and handle it in mouseDoubleClickEvent() instead of its normal button handler. This means that certain button presses might seem delayed or "swallowed" when quickly navigating forwards or backwards through the history. Since a double-click of the forward or back button is currently meaningless, fix this by emitting a normal mouseButtonPressed event for those buttons in the double-click handler and skipping any further event processing. Co-authored-by: Felix Ernst <felixernst@zohomail.eu> M +9 -0 src/kitemviews/kitemlistcontroller.cpp https://invent.kde.org/system/dolphin/-/commit/819960aed450d9aa40fd42dc42ad7119c88a4802 *** Bug 491507 has been marked as a duplicate of this bug. *** (In reply to Méven from comment #8) > Git commit 819960aed450d9aa40fd42dc42ad7119c88a4802 by Méven Car, on behalf > of Wolfgang Müller. > Committed on 17/10/2024 at 14:07. > Pushed by meven into branch 'master'. > > kitemlistcontroller: process forward/back buttons when double-clicking > > Tapping the forward or back mouse buttons quickly enough makes Dolphin > interpret the action as a double-click of the button in question and > handle it in mouseDoubleClickEvent() instead of its normal button > handler. This means that certain button presses might seem delayed or > "swallowed" when quickly navigating forwards or backwards through the > history. > > Since a double-click of the forward or back button is currently > meaningless, fix this by emitting a normal mouseButtonPressed event for > those buttons in the double-click handler and skipping any further event > processing. > > Co-authored-by: Felix Ernst <felixernst@zohomail.eu> > > M +9 -0 src/kitemviews/kitemlistcontroller.cpp > > https://invent.kde.org/system/dolphin/-/commit/ > 819960aed450d9aa40fd42dc42ad7119c88a4802 Using master branch git version (dolphin 24.11.70) and I can confirm the bug has now been fixed. Might cherry-pick to 24.08 |