Bug 484866

Summary:	Licence dialog in AboutPage opens as an overlay on top of the root application window rather than the about window
Product:	[Frameworks and Libraries] kirigami-addons	Reporter:	Jack Hill <jackhill3103>
Component:	general	Assignee:	Unassigned bugs <unassigned-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	carl
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/libraries/kirigami-addons/-/commit/5f757b8663ce0cf8395571eaf5d2c0373a226f5e	Version Fixed In:
Sentry Crash Report:

Description Jack Hill 2024-04-01 11:54:48 UTC

SUMMARY

STEPS TO REPRODUCE
1. Open Elisa
2. Open the About Elisa dialog
3. Click "Licence"

OBSERVED RESULT
Licence overlay opens in the root application page

EXPECTED RESULT
Should open as an overlay of the About window

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSUSE Tumbleweed 20240306
KDE Plasma Version: 5.7.10
KDE Frameworks Version: master
Qt Version: 6.6.2

ADDITIONAL INFORMATION

Comment 1 Bug Janitor Service 2024-06-14 09:22:39 UTC

A possibly relevant merge request was started @ https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/250

Comment 2 Jack Hill 2024-06-14 11:49:27 UTC

Git commit 5f757b8663ce0cf8395571eaf5d2c0373a226f5e by Jack Hill.
Committed on 14/06/2024 at 09:23.
Pushed by carlschwan into branch 'master'.

Open AboutPage license dialog on the correct window

Test-plan:
- Launch Elisa
- Open "About Elisa"
- Click "LGPLv3"

Before:
- License dialog opened on the main window (not the About window)

Now:
- License dialog opens on the About window

M  +1    -1    src/formcard/AboutPage.qml

https://invent.kde.org/libraries/kirigami-addons/-/commit/5f757b8663ce0cf8395571eaf5d2c0373a226f5e