Bug 484783

Summary:	Krita recorder causes freehand selection and shapes to complete early before brush stroke is complete
Product:	[Applications] krita	Reporter:	LKS <menjah_transactions>
Component:	General	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	info, moult
Priority:	NOR
Version:	5.2.0
Target Milestone:	---
Platform:	Other
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/graphics/krita/-/commit/c99b19450ccbe79356597afe1fe4213a9791378d	Version Fixed In:
Sentry Crash Report:

Description LKS 2024-03-30 21:39:31 UTC

***
If you're not sure this is actually a bug, instead post about it at https://discuss.kde.org

If you're reporting a crash, attach a backtrace with debug symbols; see https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***

SUMMARY
When Krita recorder is on, it seems that lasso selections and brush strokes are interrupted by the recorder, causing selections to complete early before pen tip is raised off tablet. Similar with non-freehand shape brushes, like rectangle circle etc

STEPS TO REPRODUCE
1. enable recorder set to small seconds interval
2. try using freehand selection/ lasso, rectangle, circle etc tool
3. usually, the selection will complete itself before your pen lifts from the surface

OBSERVED RESULT
Shapes, freehand selection tool, complete early when recorder is on

EXPECTED RESULT
recorder should not interrupt selection

SOFTWARE/OS VERSIONS
Windows: 12
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 LKS 2024-03-30 21:50:45 UTC

https://youtu.be/smtdxuQpros

Here's a short video of the issue

Comment 2 Freya Lupen 2024-04-15 13:32:47 UTC

*** Bug 485506 has been marked as a duplicate of this bug. ***

Comment 3 moult 2024-07-19 11:15:28 UTC

The bug is also/still present on MacOS 12.7.5/Krita 5.2.3.

For me at least, selections and shapes complete prematurely only if they're begun quickly after a previous selection/shape completes. If a few seconds are left after the previous one, the new one remains under control and completes correctly. Video: https://youtu.be/lA8SoRyQ4jQ

Comment 4 Dmitry Kazakov 2024-11-08 10:48:02 UTC

Git commit c99b19450ccbe79356597afe1fe4213a9791378d by Dmitry Kazakov, on behalf of Firstname Aqaao.
Committed on 08/11/2024 at 10:47.
Pushed by dkazakov into branch 'krita/5.2'.

Fixed: some tools is interrupted by recorder.

Related threads:
[bug#477715](https://bugs.kde.org/show_bug.cgi?id=477715)
[bug#484783](https://bugs.kde.org/show_bug.cgi?id=484783)

According to my tests, half of tools are affected.

This MR expanded tool blacklist and divide tools into two categories.

One is done in one step(like Line Tool), just disable recorder when such tools are activated(left button pressed on canvas).

One is done in multiple steps(like FreeHand Selection Tool), we need disable recorder in such tools all lifetime.
Related: bug 488472, bug 477715

M  +2    -0    libs/ui/canvas/kis_tool_proxy.cpp
M  +4    -1    libs/ui/canvas/kis_tool_proxy.h
M  +55   -8    plugins/dockers/recorder/recorder_writer.cpp
M  +1    -0    plugins/dockers/recorder/recorder_writer.h

https://invent.kde.org/graphics/krita/-/commit/c99b19450ccbe79356597afe1fe4213a9791378d