| Summary: | Discover crashes on launch in PackageKitDependencies::dependencies() when opened with an appstream:// URI | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Nate Graham <nate> |
| Component: | PackageKit | Assignee: | Harald Sitter <sitter> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | aleixpol |
| Priority: | HI | Keywords: | regression |
| Version First Reported In: | master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/discover/-/commit/0d16b21156263e5449c51afa5556969f297e87e0 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2024-03-29 14:34:20 UTC
`git bisect` shows this was caused by: commit b605a442ed23675f152b3a0706d03e739c5fd6ba Author: Harald Sitter <sitter@kde.org> Date: Wed Mar 27 01:02:56 2024 +0100 packagekit: only resolve dependencies for resources in None state there is little to no meaning to be gained from knowing the dependencies of an installed package libdiscover/backends/PackageKitBackend/PackageKitResource.cpp | 4 ++++ 1 file changed, 4 insertions(+) Harald, could you take a look? This commit was backported to the stable branch and is at risk of being released with Plasma 6.0.4, so unfortunately it's fairly high priority. That crash cannot happen in 6.0, can it? The commit that causes it was cherry-picked to the stable branch, so in principle it could. But to be sure, I just built Discover from the stable branch and indeed, it doesn't crash there. So the issue seems to be master-only at this point; lowering the severity. A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/809 Git commit 0d16b21156263e5449c51afa5556969f297e87e0 by Harald Sitter. Committed on 31/03/2024 at 05:00. Pushed by sitter into branch 'master'. packagekit: disarm dependencies start assertion since we have disabled dependency listing for installed software start() isn't necessarily called before dependencies() anymore. remove the assertion and instead return early M +3 -1 libdiscover/backends/PackageKitBackend/PackageKitDependencies.cpp https://invent.kde.org/plasma/discover/-/commit/0d16b21156263e5449c51afa5556969f297e87e0 |