Bug 484641

Summary: kf.i18n warning when Okular spawns wallet UI
Product: [Frameworks and Libraries] frameworks-kwallet Reporter: correctmost <cmbugz>
Component: generalAssignee: Valentin Rusu <valir>
Status: REPORTED ---    
Severity: normal CC: kdelibs-bugs-null
Priority: NOR    
Version First Reported In: 6.0.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description correctmost 2024-03-28 05:45:00 UTC 
SUMMARY
When I open a password-protected PDF with Okular, a KDE Wallet Service dialog pops up.  This causes the following warning in the system journal:

kwalletd6[58416]: kf.i18n: 0 instead of 1 arguments to message "<html><head/><body><..." supplied before conversion

STEPS TO REPRODUCE
1. Open a password-protected PDF with Okular
--> A KDE Wallet Service dialog appears
2. Run `journalctl -b 0 -p4 --since "10 minutes ago"` and notice the kf.i18n warning

OBSERVED RESULT
A warning message in the system journal

EXPECTED RESULT
No warning message in the system journal

SOFTWARE/OS VERSIONS
I am running Xfce.  The kwallet 6.0.0-3 package is from the Arch repos.

ADDITIONAL INFORMATION

The i18n issue seems to be with the string here:
https://invent.kde.org/frameworks/kwallet/-/blob/1612d6b9b4870a3f49687bc4a0eb82ca570a17c7/src/runtime/kwalletd/knewwalletdialogintro.ui#L30

Thread 1 "kwalletd6" hit Breakpoint 4, KLocalizedStringPrivate::substituteSimple (this=this@entry=0x5a38143674a0, translation=..., arguments=..., plchar=..., plchar@entry=..., 
    isPartial=isPartial@entry=false) at /usr/src/debug/ki18n/ki18n-6.0.0/src/i18n/klocalizedstring.cpp:709
709	            qCWarning(KI18N) << arguments.size() << "instead of" << ords.size() << "arguments to message" << shortenMessage(translation)

(gdb) p translation
$7 = (const QString &) @0x7fff8568f340: {d = {d = 0x5a3814375e30, 
    ptr = 0x5a3814375e40 u"<html><head/><body><p>The application '<span style=\" font-weight:600;\">%1</span>' has requested to open the KDE wallet. This is used to store sensitive data in a secure fashion. Please choose the new wallet's type below or click cancel to deny the application's request.</p></body></html>", size = 288}, static _empty = 0 u'\000'}

(gdb) bt
#0  KLocalizedStringPrivate::substituteSimple (this=this@entry=0x5a38143674a0, translation=..., arguments=..., plchar=..., plchar@entry=..., isPartial=isPartial@entry=false)
    at /usr/src/debug/ki18n/ki18n-6.0.0/src/i18n/klocalizedstring.cpp:709
#1  0x000074da71f6b5c5 in KLocalizedStringPrivate::toString
    (this=<optimized out>, domain=<optimized out>, languages=<optimized out>, format=<optimized out>, isArgument=isArgument@entry=false) at /usr/include/qt6/QtCore/qchar.h:21
#2  0x000074da71f6c682 in KLocalizedString::toString (this=this@entry=0x7fff8568f6a0) at /usr/src/debug/ki18n/ki18n-6.0.0/src/i18n/klocalizedstring.cpp:454
#3  0x00005a3813b61c87 in tr2i18nd
    (domain=0x5a3813b9e972 "kwalletd6", comment=0x0, text=0x5a3813b9f4c0 "<html><head/><body><p>The application '<span style=\" font-weight:600;\">%1</span>' has requested to open the KDE wallet. This is used to store sensitive data in a secure fashion. Please choose the new wallet's type below or click cancel to deny the application's request.</p></body></html>")
    at /usr/include/KF6/KI18n/klocalizedstring.h:951
#4  Ui_KNewWalletDialogIntro::retranslateUi (KNewWalletDialogIntro=0x74da6002b810, this=0x74da6002b838) at /usr/src/debug/kwallet/build/src/runtime/kwalletd/ui_knewwalletdialogintro.h:104
#5  Ui_KNewWalletDialogIntro::setupUi (KNewWalletDialogIntro=0x74da6002b810, this=0x74da6002b838) at /usr/src/debug/kwallet/build/src/runtime/kwalletd/ui_knewwalletdialogintro.h:95
#6  KWallet::KNewWalletDialogIntro::KNewWalletDialogIntro (parent=0x74da60029940, walletName=..., appName=..., this=0x74da6002b810)
    at /usr/src/debug/kwallet/kwallet-6.0.0/src/runtime/kwalletd/knewwalletdialog.cpp:47
#7  KWallet::KNewWalletDialog::KNewWalletDialog (parent=<optimized out>, walletName=..., appName=..., this=0x74da60029940)
    at /usr/src/debug/kwallet/kwallet-6.0.0/src/runtime/kwalletd/knewwalletdialog.cpp:26
#8  KWalletD::internalOpen (service=..., modal=<optimized out>, w=88080402, isPath=<optimized out>, wallet=..., appid=..., this=0x7fff8568fed0)
    at /usr/src/debug/kwallet/kwallet-6.0.0/src/runtime/kwalletd/kwalletd.cpp:698
#9  KWalletD::doTransactionOpen (this=0x7fff8568fed0, appid=..., wallet=..., isPath=<optimized out>, wId=88080402, modal=true, service=...)
    at /usr/src/debug/kwallet/kwallet-6.0.0/src/runtime/kwalletd/kwalletd.cpp:567
#10 0x00005a3813b6b768 in KWalletD::processTransactions (this=0x7fff8568fed0) at /usr/src/debug/kwallet/kwallet-6.0.0/src/runtime/kwalletd/kwalletd.cpp:254
#11 KWalletD::qt_static_metacall (_o=0x7fff8568fed0, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>)
    at /usr/src/debug/kwallet/build/src/runtime/kwalletd/kwalletd6_autogen/include/moc_kwalletd.cpp:934
#12 0x000074da7097c2c7 in QObject::event (this=0x7fff8568fed0, e=0x74da68009e00) at /usr/src/debug/qt6-base/qtbase-everywhere-src-6.6.2/src/corelib/kernel/qobject.cpp:1437
#13 0x000074da718f438b in QApplicationPrivate::notify_helper (this=<optimized out>, receiver=0x7fff8568fed0, e=0x74da68009e00)
    at /usr/src/debug/qt6-base/qtbase-everywhere-src-6.6.2/src/widgets/kernel/qapplication.cpp:3296
#14 0x000074da70939818 in QCoreApplication::notifyInternal2 (receiver=0x7fff8568fed0, event=event@entry=0x74da68009e00)
    at /usr/src/debug/qt6-base/qtbase-everywhere-src-6.6.2/src/corelib/kernel/qcoreapplication.cpp:1121
#15 0x000074da70939b9b in QCoreApplication::sendEvent (event=0x74da68009e00, receiver=<optimized out>)
    at /usr/src/debug/qt6-base/qtbase-everywhere-src-6.6.2/src/corelib/kernel/qcoreapplication.cpp:1539
#16 QCoreApplicationPrivate::sendPostedEvents (receiver=0x0, event_type=0, data=0x5a38142f3e90)
    at /usr/src/debug/qt6-base/qtbase-everywhere-src-6.6.2/src/corelib/kernel/qcoreapplication.cpp:1901
#17 0x000074da70b758a4 in QCoreApplication::sendPostedEvents (receiver=0x0, event_type=0) at /usr/src/debug/qt6-base/qtbase-everywhere-src-6.6.2/src/corelib/kernel/qcoreapplication.cpp:1760
#18 postEventSourceDispatch (s=0x5a38143311f0) at /usr/src/debug/qt6-base/qtbase-everywhere-src-6.6.2/src/corelib/kernel/qeventdispatcher_glib.cpp:243
#19 0x000074da6fdac199 in g_main_dispatch (context=0x74da68000f00) at ../glib/glib/gmain.c:3344
#20 0x000074da6fe0b3bf in g_main_context_dispatch_unlocked (context=0x74da68000f00) at ../glib/glib/gmain.c:4152
#21 g_main_context_iterate_unlocked.isra.0 (context=context@entry=0x74da68000f00, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/glib/gmain.c:4217
#22 0x000074da6fdab712 in g_main_context_iteration (context=0x74da68000f00, may_block=1) at ../glib/glib/gmain.c:4282
#23 0x000074da70b739c4 in QEventDispatcherGlib::processEvents (this=0x5a381433f9c0, flags=...)
    at /usr/src/debug/qt6-base/qtbase-everywhere-src-6.6.2/src/corelib/kernel/qeventdispatcher_glib.cpp:393
#24 0x000074da70943d6e in QEventLoop::processEvents (flags=..., this=0x7fff8568fd20) at /usr/src/debug/qt6-base/qtbase-everywhere-src-6.6.2/src/corelib/kernel/qeventloop.cpp:100
#25 QEventLoop::exec (this=0x7fff8568fd20, flags=...) at /usr/src/debug/qt6-base/qtbase-everywhere-src-6.6.2/src/corelib/kernel/qeventloop.cpp:182
#26 0x000074da7093c2b8 in QCoreApplication::exec () at /usr/src/debug/qt6-base/qtbase-everywhere-src-6.6.2/src/corelib/global/qflags.h:74
#27 0x000074da718f0f0a in QApplication::exec () at /usr/src/debug/qt6-base/qtbase-everywhere-src-6.6.2/src/widgets/kernel/qapplication.cpp:2574
#28 0x00005a3813b59579 in main (argc=<optimized out>, argv=<optimized out>) at /usr/src/debug/kwallet/kwallet-6.0.0/src/runtime/kwalletd/main.cpp:221