Summary: | Plasma crashes when drag'n'dropping file from notifications menu | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Petrov Egor <dikey0ficial> |
Component: | Notifications | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | dikey0ficial, kde, nate |
Priority: | NOR | Keywords: | regression |
Version: | 6.0.2 | ||
Target Milestone: | 1.0 | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/bf8545946cc340c262911c0ba94e28661a7feb8a | Version Fixed In: | 6.1 |
Description
Petrov Egor
2024-03-26 19:39:44 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4295 Git commit bf8545946cc340c262911c0ba94e28661a7feb8a by Kai Uwe Broulik. Committed on 14/05/2024 at 12:30. Pushed by broulik into branch 'master'. Notifications: Restore custom DragHelper When the notification popup closes, the ListView mode is unloaded to save some resources. On Wayland, during drag and drop another window might be raised and focussed causing the notification popup to close. QtQuick's built-in drag handling does not take kind to having the item it's operating on destroyed behind its back, particularly because it uses a freaking' nested event loop inside of dragStarted! Restore the original DragHandler which detaches the drag operation entirely from the item that triggered it. It also creates a proper drag pixmap for dragging the file icon and keeps it for the entire duration of the drag. As a bonus this also lets us export the URL to the Document portal to enable drag and drop of thumbnails to sandboxed apps. Related: bug 486665 M +3 -0 applets/notifications/CMakeLists.txt A +84 -0 applets/notifications/draghelper.cpp [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)] A +42 -0 applets/notifications/draghelper.h [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)] M +4 -0 applets/notifications/notificationapplet.cpp M +10 -9 applets/notifications/package/contents/ui/DraggableFileArea.qml M +2 -5 applets/notifications/package/contents/ui/JobItem.qml M +2 -5 applets/notifications/package/contents/ui/ThumbnailStrip.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/bf8545946cc340c262911c0ba94e28661a7feb8a |