Bug 484489

Summary: Localised percent values are not reflected to UI
Product: [Applications] ktorrent Reporter: Emir SARI <emir_sari>
Component: generalAssignee: Joris Guisson <joris.guisson>
Status: REPORTED ---    
Severity: normal    
Priority: NOR    
Version First Reported In: 24.02.1   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Emir SARI 2024-03-25 22:33:22 UTC 
A while ago, I've enabled localisations for all the percent values in KTorrent. However, checking now the latest Git copy, although the values have been translated long ago, they do not seem to be reflected into the UI.

To test easily, start KTorrent from the terminal with the LANG=tr variable. Normally you should see the percent values on the main table view with the %100 format. However, they are still in 100% format.

There is one in the accessibility column in the info pane, it still reflects the original string in "100 %" format. But in code they are all translated, and should be %100.

Something simple, yet my mind cannot comprehend. What could be the reason?
Comment 1 Bug Janitor Service 2024-03-26 16:33:38 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/network/ktorrent/-/merge_requests/116
Comment 2 Emir SARI 2024-03-27 11:16:04 UTC 
Git commit b54e21becb0ac8363b0eca632bf215738305ebee by Emir SARI.
Committed on 27/03/2024 at 11:14.
Pushed by esari into branch 'master'.

Apply i18n to percent values

M  +3    -1    ktorrent/view/viewdelegate.cpp
M  +1    -1    plugins/infowidget/peerviewmodel.cpp

https://invent.kde.org/network/ktorrent/-/commit/b54e21becb0ac8363b0eca632bf215738305ebee