Bug 484386

Summary:	Solarised theme inconsistent black/gray
Product:	[Applications] konsole	Reporter:	Arthur Bols <arthur>
Component:	font	Assignee:	Konsole Developer <konsole-devel>
Status:	CONFIRMED ---
Severity:	normal	CC:	kde
Priority:	NOR
Version:	23.08.5
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:

Description Arthur Bols 2024-03-24 14:13:30 UTC

SUMMARY
Solarised theme doesn't show "gray/bright black" `\x1b[90m` color. This color is shown on all other themes, where "black" `\x1b[30m` is used as background color.

This issue is a duplicate of #366143 but I believe it should be solved. It is really difficult for CLI developers to be compatible with all themes and terminals, and inconsistency doesn't help. For example, in the python termcolor library, "black/grey" is invisible on most dark themes, but "dark_grey" is shown, except when using the Solarised theme. So this means to be compatible with all Konsole themes, it is not possible to use a greyish color.

This also causes a different problem where my cursor is sometimes not visible. Overall it's not a good experience.


STEPS TO REPRODUCE
1. Switch to breeze theme
2. echo -ne '\x1b[30mBLACK\x1b[0m' 
3. echo -ne '\x1b[90mGREY\x1b[0m'
4. Switch to Solarised theme

OBSERVED RESULT
- They "BLACK" text is invisible and GREY is visible when using the breeze theme
- They "BLACK" text is slightly visible and GREY is invisible when using the solarised theme

EXPECTED RESULT
- They "BLACK" text is invisible and GREY is visible when using the solarised theme

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Fedora Linux 39
KDE Plasma Version: 5.27.11
KDE Frameworks Version: 5.115.0
Qt Version: 5.15.12

ADDITIONAL INFORMATION

I would be happy to open a pull request with the needed changes, if this issue is accepted.

Comment 1 Tammes Burghard 2024-03-24 17:20:14 UTC

I can confirm that these colors are visible/invisible as you describe. But, as far as I know, Solarized is a third party theme not provided by KDE, so we can't do anything about it here and you will have to ask the theme's developer instead. Where did you get the theme from?

Comment 2 Arthur Bols 2024-03-24 17:26:46 UTC

(In reply to Tammes Burghard from comment #1)
> I can confirm that these colors are visible/invisible as you describe. But,
> as far as I know, Solarized is a third party theme not provided by KDE, so
> we can't do anything about it here and you will have to ask the theme's
> developer instead. Where did you get the theme from?

I believe this is built-in? https://invent.kde.org/utilities/konsole/-/blob/release/24.02/data/color-schemes/Solarized.colorscheme

Comment 3 Tammes Burghard 2024-03-24 17:28:32 UTC

Oh yes, looks like it is. Sorry

Comment 4 Kurt Hindenburg 2024-04-26 22:09:26 UTC

Please provide a MR w/ the changes you want.  Please provide before and after screenshots.