Bug 484322

Summary: Escape Key does not close image view
Product: [Applications] NeoChat Reporter: Marco Parillo <marco_parillo>
Component: GeneralAssignee: Tobias Fella <fella>
Status: RESOLVED FIXED    
Severity: normal CC: carl, demm, josh, robert, smowtenshi
Priority: NOR    
Version First Reported In: 24.02.1   
Target Milestone: ---   
Platform: KaOS   
OS: Linux   
Latest Commit: https://invent.kde.org/network/neochat/-/commit/953b71182347c0dfb989e63d85d3da86515fdcf5 Version Fixed/Implemented In: 24.12
Sentry Crash Report:

Description Marco Parillo 2024-03-23 13:55:05 UTC 
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. Click on Image
2. See image expand to almost the full screen
3. Hit escape

OBSERVED RESULT

Nothing happens

EXPECTED RESULT

The image should disappear, and you should return to the normal chat view.

ADDITIONAL INFORMATION

Clicking the close button works fine.

Operating System: KaOS (2024) 
KDE Plasma Version: 6.0.2
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Kernel Version: 6.7.9-1 (64-bit)
Graphics Platform: Wayland
Processors: 8 × 11th Gen Intel® Core™ i7-1185G7 @ 3.00GHz
Memory: 15.0 GiB of RAM
Graphics Processor: Mesa Intel® Xe Graphics
Manufacturer: Dell Inc.
Product Name: Latitude 5420
Comment 1 Marco Parillo 2024-04-18 21:53:32 UTC 
I wonder if it is a focus issue. After I click on the image to enlarge, escape does nothing, but if I click on the image to enlarge, and then select either the previous or next image buttons on the left or right side, then escape does close the second image.
Comment 2 James Graham 2024-05-19 16:25:07 UTC 
*** Bug 487159 has been marked as a duplicate of this bug. ***
Comment 3 Bug Janitor Service 2024-11-09 22:09:35 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/1969
Comment 4 Joshua Goins 2024-11-09 23:10:28 UTC 
Git commit a41d0f321417b8076248c8235ab098ae937e2947 by Joshua Goins.
Committed on 09/11/2024 at 23:10.
Pushed by redstrate into branch 'master'.

Make fullscreen images focused when they're opened

Otherwise keyboard shortcuts don't work until you tap the image, which
makes no sense.

M  +2    -0    src/qml/NeochatMaximizeComponent.qml
M  +2    -0    src/qml/QrCodeMaximizeComponent.qml

https://invent.kde.org/network/neochat/-/commit/a41d0f321417b8076248c8235ab098ae937e2947
Comment 5 Joshua Goins 2024-11-09 23:12:37 UTC 
Git commit 953b71182347c0dfb989e63d85d3da86515fdcf5 by Joshua Goins.
Committed on 09/11/2024 at 23:12.
Pushed by redstrate into branch 'release/24.12'.

Make fullscreen images focused when they're opened

Otherwise keyboard shortcuts don't work until you tap the image, which
makes no sense.
(cherry picked from commit a41d0f321417b8076248c8235ab098ae937e2947)

M  +2    -0    src/qml/NeochatMaximizeComponent.qml
M  +2    -0    src/qml/QrCodeMaximizeComponent.qml

https://invent.kde.org/network/neochat/-/commit/953b71182347c0dfb989e63d85d3da86515fdcf5