Bug 484174

Summary: Clicking on the dark overlay of the save dialog makes it disappear
Product: [Applications] krecorder Reporter: Simone Gaiarin <simgunz>
Component: generalAssignee: Devin Lin <espidev>
Status: RESOLVED FIXED    
Severity: major    
Priority: NOR    
Version First Reported In: 23.08.5   
Target Milestone: ---   
Platform: Manjaro   
OS: Linux   
Latest Commit: https://invent.kde.org/utilities/krecorder/-/commit/17c3f1c30cda392c826bca857321a641d80fe9a1 Version Fixed/Implemented In: 24.02.2
Sentry Crash Report:

Description Simone Gaiarin 2024-03-21 15:49:43 UTC 
SUMMARY
Clicking on the dark overlay of the save dialog makes it disappear and the recording cannot be saved anymore.


STEPS TO REPRODUCE
1. Click stop recording
2. (Save dialog appears)
3. Click on the shadow background of the window

OBSERVED RESULT
The save dialog disappear. Clicking on the record button does not start a new recording, instead the previous recording is shown. Clicking on stop again displays the dialog again and the recording can be saved.

EXPECTED RESULT
The save dialog is not closed until the user makes a choice.

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux 
KDE Plasma Version: 5.27.11
KDE Frameworks Version: 5.115.0
Qt Version: 5.15.12
Kernel Version: 6.6.19-1-MANJARO (64-bit)
Graphics Platform: X11
Processors: 16 × AMD Ryzen 7 PRO 7840U w/ Radeon 780M Graphics
Memory: 58,6 GiB of RAM
Graphics Processor: AMD Radeon Graphics


ADDITIONAL INFORMATION
Comment 1 Bug Janitor Service 2024-03-22 01:32:57 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/utilities/krecorder/-/merge_requests/36
Comment 2 Devin Lin 2024-03-22 01:33:57 UTC 
Git commit 7566bf3259ec2dd273a30d4fb33ffb8fc85c817b by Devin Lin.
Committed on 22/03/2024 at 01:30.
Pushed by devinlin into branch 'master'.

Don't allow recording save dialog to be easily closed from clicking the scrim

Make it harder to accidentally close the dialog, as the user may be confused and in for a shock in thinking that they accidentally deleted their recording.

It is still possible to close the dialog, with the "close" button.

M  +1    -0    src/contents/ui/RecordPage.qml

https://invent.kde.org/utilities/krecorder/-/commit/7566bf3259ec2dd273a30d4fb33ffb8fc85c817b
Comment 3 Devin Lin 2024-03-22 01:34:18 UTC 
Git commit 17c3f1c30cda392c826bca857321a641d80fe9a1 by Devin Lin.
Committed on 22/03/2024 at 01:34.
Pushed by devinlin into branch 'release/24.02'.

Don't allow recording save dialog to be easily closed from clicking the scrim

Make it harder to accidentally close the dialog, as the user may be confused and in for a shock in thinking that they accidentally deleted their recording.

It is still possible to close the dialog, with the "close" button.

M  +1    -0    src/contents/ui/RecordPage.qml

https://invent.kde.org/utilities/krecorder/-/commit/17c3f1c30cda392c826bca857321a641d80fe9a1