| Summary: | Crash when pasting/changing? font name in multiple text objects | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | myrtlemistmusic |
| Component: | Tool/Text | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | penguinflyer2222 |
| Priority: | NOR | ||
| Version: | 5.2.2 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/-/commit/012ab13a68d5dd10cc12eec5b1695c434c7e7a44 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
myrtlemistmusic
2024-03-20 12:57:38 UTC
After further messing with this error I think I pinned down the issue further. Krita crashes when you paste in a new font name, and save without pressing enter to allow the font to change. Also apologies if my report may have sounded a bit passive-aggressive initially. This bug was frustrating me and making me lose progress repeatedly for the last hour. Confirmed on 5.3-prealpha git 1a2dd9786e (and 5.1.5). Pasting a new font name and hitting Save or Discard while the font line-edit is still in editing focus crashes. A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/2102 Git commit 49dc9e050aeb05f7a313f5766c5edd2d5638a6b7 by Dmitry Kazakov, on behalf of Igor Danilets. Committed on 29/03/2024 at 11:10. Pushed by dkazakov into branch 'master'. Fix crash when pasting font family in TextEditor Problem: Pasting a new font famyly and hitting Save or Discard while the FontFamilyComboBox is still in editing focus crashes. After pasting font family, the font is also not applied until you press enter or change focus. Solution: Write the validator of the font familyies. Validator is triggered whenever the text is changed (including pasting), and if font famyly is correct, the font changes immediately. So, there are no conditions that provoke a crash. M +1 -0 libs/widgetutils/CMakeLists.txt A +41 -0 libs/widgetutils/KisFontFamilyValidator.cpp [License: GPL(v3.0+)] A +27 -0 libs/widgetutils/KisFontFamilyValidator.h [License: GPL(v3.0+)] M +15 -0 libs/widgetutils/kis_font_family_combo_box.cpp M +3 -0 libs/widgetutils/kis_font_family_combo_box.h https://invent.kde.org/graphics/krita/-/commit/49dc9e050aeb05f7a313f5766c5edd2d5638a6b7 Git commit 012ab13a68d5dd10cc12eec5b1695c434c7e7a44 by Dmitry Kazakov, on behalf of Igor Danilets. Committed on 01/04/2024 at 11:11. Pushed by dkazakov into branch 'krita/5.2'. Fix crash when pasting font family in TextEditor Problem: Pasting a new font famyly and hitting Save or Discard while the FontFamilyComboBox is still in editing focus crashes. After pasting font family, the font is also not applied until you press enter or change focus. Solution: Write the validator of the font familyies. Validator is triggered whenever the text is changed (including pasting), and if font famyly is correct, the font changes immediately. So, there are no conditions that provoke a crash. (cherry picked from commit 49dc9e050aeb05f7a313f5766c5edd2d5638a6b7) 6762569e Fix crash when pasting font family in TextEditor 86af950d Fix crash when pasting font family in TextEditor 4dd9100b Fix crash when pasting font family in TextEditor M +1 -0 libs/widgetutils/CMakeLists.txt A +41 -0 libs/widgetutils/KisFontFamilyValidator.cpp [License: GPL(v3.0+)] A +27 -0 libs/widgetutils/KisFontFamilyValidator.h [License: GPL(v3.0+)] M +15 -0 libs/widgetutils/kis_font_family_combo_box.cpp M +3 -0 libs/widgetutils/kis_font_family_combo_box.h https://invent.kde.org/graphics/krita/-/commit/012ab13a68d5dd10cc12eec5b1695c434c7e7a44 |