| Summary: | Triggering a floating change invokes PanelView::updateFloating() 13 times, so its animation isn't smooth | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Fushan Wen <qydwhotmail> |
| Component: | Panel | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | FishBoneEK, nate, niccolo.venerandi |
| Priority: | NOR | Keywords: | efficiency |
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=475468 | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/428dd6ef576e3f3b1a412ab345de1805b0113156 | Version Fixed In: | 6.1 |
| Sentry Crash Report: | |||
|
Description
Fushan Wen
2024-03-15 15:08:04 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2126 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4075 Git commit 9d78c7816fa21a0bf688992e212d51b4d4bb09d3 by Fushan Wen. Committed on 18/03/2024 at 13:28. Pushed by fusionfuture into branch 'master'. Panel: adapt to PanelView changes M +10 -14 desktoppackage/contents/views/Panel.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/9d78c7816fa21a0bf688992e212d51b4d4bb09d3 Git commit 428dd6ef576e3f3b1a412ab345de1805b0113156 by Fushan Wen. Committed on 18/03/2024 at 15:19. Pushed by fusionfuture into branch 'master'. PanelView: make floating panel more efficient When floatingness is changed by QML Animation, updateFloating() is called many times, and updateMask() is called at least 26 times, but some parts of updateFloating() don't need to be called more than once. By moving the animation to PanelView, PanelView doesn't need to subscribe to floatingness changes in QML, instead the floatingness property is modified by QPropertyAnimation in PanelView, which prevents some potentially expensive operations from being called many times when the floating state changes once. FIXED-IN: 6.1 M +44 -14 shell/panelview.cpp M +6 -3 shell/panelview.h https://invent.kde.org/plasma/plasma-workspace/-/commit/428dd6ef576e3f3b1a412ab345de1805b0113156 *** Bug 484147 has been marked as a duplicate of this bug. *** |