Bug 483659

Summary: Multiple files download dialog works from the front page but not from the product's page
Product: [Frameworks and Libraries] frameworks-knewstuff Reporter: nttkde <watisthispoo>
Component: generalAssignee: Dan Leinir Turthra Jensen <admin>
Status: RESOLVED FIXED    
Severity: normal CC: akselmo, alexander.lohnau, john.kde, kdelibs-bugs-null, nate
Priority: NOR Keywords: qt6
Version First Reported In: 6.0.0   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: https://invent.kde.org/frameworks/knewstuff/-/commit/f8fb221d6f355c4f0873592fbf7dce358f4f0b40 Version Fixed/Implemented In: 6.5
Sentry Crash Report:

Description nttkde 2024-03-15 12:45:31 UTC 
Steps to reproduce:
Open Get New... dialog from system settings and find eg. a theme or a cursor theme that provides multiple user-downloadable files. 
Instead of clicking at the Install... button above the new stuff product on the 'front page' that lists all products, click the product to open its own page view and click the Install... button on top right and then try to install one of the files: the selection dialog closes but nothing seems to happen; the theme doesn't get installed.
The following entry is logged in console: 
qrc:/qt/qml/org/kde/newstuff/EntryDetails.qml:86: ReferenceError: entryId is not defined

KDE Neon User Edition
KDE Plasma Version: 6.0.2
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Graphics Platform: Wayland
Comment 2 Akseli Lahtinen 2024-07-12 12:58:56 UTC 
Git commit f8fb221d6f355c4f0873592fbf7dce358f4f0b40 by Akseli Lahtinen.
Committed on 12/07/2024 at 12:58.
Pushed by akselmo into branch 'master'.

EntryDetails.qml: Qualify newStuffModel, use downloadItemId

There is no such thing as entryId, change it to downloadItemId
Otherwise the item wont download anything.

This fixes a bug where in detailed item view, if the list with multiple downloads
appears and user clicks download, nothing would happen and knewstuff would report this
warning in terminal: `qrc:/qt/qml/org/kde/newstuff/EntryDetails.qml:88: ReferenceError: entryId is not defined`

After this fix it will download items.

M  +2    -2    src/qtquick/qml/EntryDetails.qml

https://invent.kde.org/frameworks/knewstuff/-/commit/f8fb221d6f355c4f0873592fbf7dce358f4f0b40