Bug 483593

Summary: ConfigOverlay.qml:288: TypeError: Cannot read property 'applet' of null when adding a widget
Product: [Plasma] plasmashell Reporter: Jakub <jjaruszewski>
Component: PanelAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: niccolo.venerandi, niccolo
Priority: NOR Keywords: qt6
Version First Reported In: 6.0.2   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/-/commit/d2cf450f8f3c372da4993d3a18634a0b4ee02bf7 Version Fixed/Implemented In:
Sentry Crash Report:

Description Jakub 2024-03-14 19:00:05 UTC 
SUMMARY
This does not happen always, but it's easiest to reproduce while adding an applet from "Plasma 6 clocks" category in store. Happened to me with KDE ModernClock (https://store.kde.org/p/2135653) (but happens with others too). It's 90% reproducible, but if you happen to successfully place the widget, error does not happen again.

My guess is that ConfigOverlay.qml:288 does not check for existence of `currentApplet` (like in bug https://bugs.kde.org/show_bug.cgi?id=335268 but different line number)


STEPS TO REPRODUCE
1. Add KDE Moder Clock to your desktop


OBSERVED RESULT
Plasma crashes 9/10 times :/

EXPECTED RESULT
Plasma does not crash :)

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux 
KDE Plasma Version: 6.0.2
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Kernel Version: 6.7.9-1-MANJARO (64-bit)
Graphics Platform: Wayland
Processors: 16 × 12th Gen Intel® Core™ i7-12650H
Memory: 31.0 GiB of RAM
Graphics Processor: Mesa Intel® Graphics
Manufacturer: ASUSTeK COMPUTER INC.
Product Name: Vivobook_ASUSLaptop N7601ZM_N7601ZM
System Version: 1.0
Comment 2 Niccolò Venerandi 2024-03-18 13:50:56 UTC 
I'll do a MR with your suggestion as that should certainly hide the error, but it really shouldn't be crashing!
Comment 3 Jakub 2024-03-18 14:46:55 UTC 
(In reply to Niccolò Venerandi from comment #2)
> I'll do a MR with your suggestion as that should certainly hide the error,
> but it really shouldn't be crashing!

I did some investigating and you're right, this error is not the reason of the crash! Actually plasma segfaults in libfreetype.so.6.20.1 when adding a plasmoid using custom font (and bug appears in "Plasma 6 clocks" since they often use custom fonts). I will create a separate bug report for that and link it here
Comment 4 Jakub 2024-03-18 19:55:37 UTC 
Filed a related bug report at: https://bugs.kde.org/show_bug.cgi?id=483932
Comment 5 Bug Janitor Service 2024-03-21 11:56:16 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2135
Comment 6 Niccolò Venerandi 2024-03-22 07:14:42 UTC 
Git commit 8fd109b565f7f8a0b1774fc0dc07645dc22732c7 by Niccolò Venerandi.
Committed on 22/03/2024 at 07:14.
Pushed by niccolove into branch 'master'.

Check for applet in ConfigOverlay to avoid startup error messages

M  +1    -1    containments/panel/contents/ui/ConfigOverlay.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/8fd109b565f7f8a0b1774fc0dc07645dc22732c7
Comment 7 ratijas 2024-04-19 19:56:43 UTC 
Git commit d2cf450f8f3c372da4993d3a18634a0b4ee02bf7 by ivan tkachenko.
Committed on 19/04/2024 at 19:56.
Pushed by ratijas into branch 'master'.

Check for applet AND provide a fallback in ConfigOverlay to avoid startup error messages

Amends 8fd109b565f7f8a0b1774fc0dc07645dc22732c7

M  +1    -1    containments/panel/contents/ui/ConfigOverlay.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/d2cf450f8f3c372da4993d3a18634a0b4ee02bf7