Summary: | Ark crashed while restarting plasmashell | ||
---|---|---|---|
Product: | [Applications] ark | Reporter: | leadpogrommer |
Component: | general | Assignee: | Elvis Angelaccio <elvis.angelaccio> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | nicolas.fella, rthomsen6 |
Priority: | NOR | Keywords: | drkonqi, qt6 |
Version: | 24.02.0 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/kjobwidgets/-/commit/6f3496ce99d5cb9e4ce561d0bfc3b703fe9eec24 | Version Fixed In: |
Description
leadpogrommer
2024-03-14 17:14:59 UTC
This looks like a slightly different variant of https://bugs.kde.org/show_bug.cgi?id=471531 https://invent.kde.org/frameworks/kjobwidgets/-/merge_requests/46 was supposed to fix that, but I don't think the fix makes sense A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kjobwidgets/-/merge_requests/53 Git commit 6f3496ce99d5cb9e4ce561d0bfc3b703fe9eec24 by Christoph Cullmann, on behalf of Méven Car. Committed on 07/05/2024 at 19:28. Pushed by cullmann into branch 'master'. KUiServerV2JobTracker: prevent a crash Related: bug 471531 This is a very-common crash, happening when plasma crashes itself: https://crash-reports.kde.org/organizations/kde/issues/10390/activity/?project=4&query=is%3Aunresolved&referrer=issue-stream&stream_index=0 I think this is due to the line 204 indeed, dereferencing a jobViews key, which is nullptr, because the `QTimer::timeout` callback in `KUiServerV2JobTracker::registerJob` did implicitely insert a jobViews[nullptr] when the job was already removed. Guard with jobGuard. The first change is not necessary but I felt it makes the code implicit, otherwise we have a QPointer implicit conversion to `*`. cc @broulik M +5 -6 src/kuiserverv2jobtracker.cpp https://invent.kde.org/frameworks/kjobwidgets/-/commit/6f3496ce99d5cb9e4ce561d0bfc3b703fe9eec24 |