Bug 483299

Summary:	Make it easier to exit panel editing mode
Product:	[Plasma] plasmashell	Reporter:	jan.claussen10
Component:	Panel	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	nate, niccolo.venerandi, postix
Priority:	NOR	Keywords:	qt6, usability
Version First Reported In:	6.0.1
Target Milestone:	1.0
Platform:	Other
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=486703
Latest Commit:	https://invent.kde.org/plasma/plasma-desktop/-/commit/52d352fb32abd876fdfd51fd5c9ed28ce73b0442	Version Fixed/Implemented In:	6.1
Sentry Crash Report:

Description jan.claussen10 2024-03-11 22:48:50 UTC

SUMMARY
The "Remove panel" button is imo too big and should be exchanged with an "exit edit mode" button. I am using the panel as a Dock on the left side and every time I want to exit editing mode, I have to drag the cursor to the upper right edge to leave this mode. A button to exit editing mode would be used far more often than one for removing a panel. The "remove panel" button should imo also be less prominent and hidden inside e.g. hamburger menu.

STEPS TO REPRODUCE
1. Edit panel on the left edge
2. Try to exit the panel
3. Click by mistake on "remove panel"
4. Revert "remove panel"
5. Find the button to exit editing mode on the other end of the screen
6. Exit editing mode. Finally

OBSERVED RESULT
Could be improved UX-wise

SOFTWARE/OS VERSIONS
KDE Plasma Version: 6.0.1
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2

Comment 1 Nate Graham 2024-03-13 15:24:43 UTC

In progress with https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2021.

Comment 2 Bug Janitor Service 2024-05-07 22:40:12 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2240

Comment 3 Nate Graham 2024-05-10 00:42:49 UTC

Git commit 52d352fb32abd876fdfd51fd5c9ed28ce73b0442 by Nate Graham.
Committed on 10/05/2024 at 00:42.
Pushed by ngraham into branch 'master'.

PanelConfiguration: make it more obvious how you close it

Right now, there's no clear way to close the panel configuration dialog.
It lacks both an OK or Done button like you'd see in a dialog, and also
a close button in the fake titlebar like you'd see in a real window.
The dialog also doesn't disappear on focus loss like the old UI did.

This isn't ideal. Let's address it by adding a "Done" button to the
bottom-trailing position, where people generally expect to see buttons
to close dialogs.

I chose this over a close button in the fake titlebar because a close
button (especially a red one, as the Breeze icon is) might be seen more
negatively, i.e. "throw away settings". Whereas a "Done" button with
a checkmark is clearly an affirmative action that will accept and save
any changed settings.

To make room, the Delete Panel button is moved to the other side of the
footer, and the shortcut UI is added into the body of the dialog, where
the thickness control lives.

---

Thanks to @eatsu for starting this off in https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2021.

This is an intentionally minimal change to fix a targeted UX issue; let's try to avoid redesigning the entire dialog or else we'll go in circles like we did there.

Co-authored-by: Taro Tanaka <mkrmdk@gmail.com>
Related: bug 486703
FIXED-IN: 6.1

@teams/vdg @teams/usability

| Before | After |
| ------ | ----- |
| ![Before](/uploads/e74e84963544a4d4a5e35ed4245ed951/Before.jpeg) | ![After](/uploads/17e217a34b5ff5809491764afcb5ef32/After.jpeg) |

M +43 -26 desktoppackage/contents/configuration/PanelConfiguration.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/52d352fb32abd876fdfd51fd5c9ed28ce73b0442