| Summary: | Better customization options when selecting the retrieval type | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] alkimia | Reporter: | Ralf Habacker <ralf.habacker> |
| Component: | Online quotes widget | Assignee: | KMyMoney Devel Mailing List <kmymoney-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | 8.1.2 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/office/alkimia/-/commit/23203854264b5837939be9e7bb0bb4d19e9915df | Version Fixed In: | 8.2 |
| Sentry Crash Report: | |||
|
Description
Ralf Habacker
2024-03-10 17:15:43 UTC
(In reply to Ralf Habacker from comment #0) > The selection of this type of retrieval > is currently realized via a '.webkit' suffix in the name of the respective > online source. Also the suffix '.webkit' does not match the engine used with webengine enabled. With this refactoring, the associated unit tests should be separated in order to be able to determine more precisely which one fails. A possibly relevant merge request was started @ https://invent.kde.org/office/alkimia/-/merge_requests/28 Git commit 22cf1b34229bad8ea2d8d1eaa7b31439f0c2ae86 by Ralf Habacker. Committed on 27/03/2024 at 18:00. Pushed by habacker into branch 'master'. Add class AlkDownloadEngine with associated unit tests FIXED-IN:8.2 M +1 -0 CMakeLists.txt M +31 -4 autotests/CMakeLists.txt A +221 -0 autotests/alkdownloadenginetest.cpp [License: LGPL(v2.1+)] A +33 -0 autotests/alkdownloadenginetest.h [License: LGPL(v2.1+)] M +3 -0 src/CMakeLists.txt A +344 -0 src/alkdownloadengine.cpp [License: LGPL(v2.1+)] A +122 -0 src/alkdownloadengine.h [License: LGPL(v2.1+)] M +61 -239 src/alkonlinequote_p.cpp M +8 -13 src/alkonlinequote_p.h M +3 -0 src/alktestdefs.h M +26 -1 src/alkwebpage.cpp M +3 -0 src/alkwebpage.h https://invent.kde.org/office/alkimia/-/commit/22cf1b34229bad8ea2d8d1eaa7b31439f0c2ae86 Git commit 23203854264b5837939be9e7bb0bb4d19e9915df by Ralf Habacker. Committed on 27/03/2024 at 18:00. Pushed by habacker into branch 'master'. Add download type to class AlkOnlineQuote[Source] and in ui With this commit one instance of class AlkWebPage is used for downloading and showing the html content, which fixed bug 479440. Related: bug 479440 FIXED-IN:8.2 M +11 -7 autotests/alkonlinequotetest.cpp M +1 -1 autotests/alkonlinequotetest.h M +7 -5 src/alkonlinequote.cpp M +55 -54 src/alkonlinequote_p.cpp M +5 -5 src/alkonlinequote_p.h M +120 -111 src/alkonlinequotedetails.ui M +31 -1 src/alkonlinequotesource.cpp M +11 -2 src/alkonlinequotesource.h M +18 -17 src/alkonlinequotesource_p.h M +25 -1 src/alkonlinequotesprofile_p.cpp M +2 -0 src/alkonlinequotesprofile_p.h M +11 -0 src/alkonlinequoteswidget.cpp https://invent.kde.org/office/alkimia/-/commit/23203854264b5837939be9e7bb0bb4d19e9915df |