| Summary: | CPU core label collapses in the wrong way when there's not enough space | ||
|---|---|---|---|
| Product: | [Applications] plasma-systemmonitor | Reporter: | Hesam Gholami <hesamgholami> |
| Component: | general | Assignee: | KSysGuard Developers <ksysguard-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | ahiemstra, nate, plasma-bugs |
| Priority: | NOR | Keywords: | qt6 |
| Version First Reported In: | 6.0.1 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/ksystemstats/-/commit/f4b57a9f8c0bb51388b608d3cd55f54d382a7743 | Version Fixed In: | 6.1 |
| Sentry Crash Report: | |||
| Attachments: |
Systerm monitor history page showing inconsistent labels for cores more after 10th
Making window wider will fix the issue |
||
If you make the window wider, do the labels change? Created attachment 166713 [details]
Making window wider will fix the issue
Making window wider will fix the problem
Yes If I make the window wider it will show the labels. the problem is it takes one characters for 1 to 9 and two characters for 10 to 20. So I think the proper solution is to pad 1 to 9 with an additional space if cpu cores are more than 10. So it will be like this: Core 1 Total Usage %1.0 --> notice additional space for padding here Core 10 Total Usage %1.0 It looks like the collapse behavior is wrong here. It's truncating the left side of the string instead of the right. A possibly relevant merge request was started @ https://invent.kde.org/plasma/ksystemstats/-/merge_requests/81 Git commit f4b57a9f8c0bb51388b608d3cd55f54d382a7743 by Arjen Hiemstra, on behalf of Zhangzhi Hu. Committed on 22/05/2024 at 09:09. Pushed by ahiemstra into branch 'master'. Fix collapse behavior of CPU usage per core The collapse behavior of CPU usage per core is incorrect. For an example, when space is insufficient, "Core 1 Total Usage 1.0%" will collapse into "Usage 1.0%", which is hard to distinguish among different cores. Therefore, we should make it collapses into core No. (such as "Core 1"). M +6 -6 plugins/cpu/cpu.cpp https://invent.kde.org/plasma/ksystemstats/-/commit/f4b57a9f8c0bb51388b608d3cd55f54d382a7743 |
Created attachment 166591 [details] Systerm monitor history page showing inconsistent labels for cores more after 10th SUMMARY In system monitor application there is a history section which shows a history of CPU core utilization. For every cpu core it assigns a color and a label like 'Core 1 Total Usage %1.0'. For cpus that have more than 10 cores, it uses another label like this: 'Usage 1.0%' I've attached an image to better describe the error. I'm pretty sure this was not the case in Plasma 5 and I'm seeing this in Plasma 6.0.1. STEPS TO REPRODUCE 1. A cpu with more than 10 cores 2. Open up system monitor application 3. Navigate to History tab OBSERVED RESULT CPU core labels after 10th core are different from previous ones. EXPECTED RESULT CPU core labels after the 10th one also should be same as previous ones. SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 6.0.1 KDE Frameworks Version: 6.0.0 Qt Version: 6.6.2 Kernel Version: 6.7.8-arch1-1 (64-bit) Graphics Platform: Wayland Processors: 20 × Intel® Core™ i9-10900 CPU @ 2.80GHz Memory: 62.6 GiB of RAM Graphics Processor: NVIDIA GeForce GTX 1650/PCIe/SSE2 Manufacturer: ASUS ADDITIONAL INFORMATION N/A