Summary: | GHNS dialog's default size is too small when invoked from Widget Explorer | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-knewstuff | Reporter: | Kalzi <kalzwayed> |
Component: | general | Assignee: | Nate Graham <nate> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | alexander.lohnau, kdelibs-bugs, nate, plasma-bugs |
Priority: | NOR | Keywords: | usability |
Version: | 6.0.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/knewstuff/-/commit/2dae07f0769f6e8054cc0facd2c5d27bafaa9e0f | Version Fixed In: | Frameworks 6.1 |
Attachments: | small window |
Description
Kalzi
2024-03-06 22:46:30 UTC
This happens on both wayland and x11 It seems like the default dialog size isn't being used when invoked from the Widget Explorer here the way it is for other invocations of it (e.g. in System Settings KCMs). The code in Widget Explorer looks sane enough though. Found the bug: constructing a dialog from the C++ method gives it a different size than doing so via QML. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knewstuff/-/merge_requests/299 Git commit 2dae07f0769f6e8054cc0facd2c5d27bafaa9e0f by Nate Graham. Committed on 15/03/2024 at 04:39. Pushed by ngraham into branch 'master'. Unify default sizes Right now there are three different sizes for: - The dialog when invoked from QML - The dialog when invoked from C++ - The page (which doesn't even matter since its size is based on the parent view, but still) Let's synchronize these to prevent oddness. FIXED-IN: 6.1 M +2 -0 src/qtquick/qml/Dialog.qml M +3 -2 src/qtquick/qml/DialogContent.qml M +5 -3 src/widgets/dialog.cpp https://invent.kde.org/frameworks/knewstuff/-/commit/2dae07f0769f6e8054cc0facd2c5d27bafaa9e0f |