| Summary: | Merkuro Calandar starting wrong week in week-view | ||
|---|---|---|---|
| Product: | [Applications] Merkuro | Reporter: | throttlemeister |
| Component: | general | Assignee: | Claudio Cambra <claudio.cambra> |
| Status: | ASSIGNED --- | ||
| Severity: | normal | CC: | carl, farchord, moschlegbz, snow |
| Priority: | NOR | ||
| Version First Reported In: | 23.08.4 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | Calendar | ||
|
Description
throttlemeister
2024-03-05 18:10:42 UTC
Updated information after upgrade to Plasma 6, bug is there as well. SOFTWARE/OS VERSIONS Linux/KDE Plasma: OpenSUSE Tumbleweed, kernel 6.7.9-1, KDE Plasma 6, Merkuro 24.02.0 (available in About System) KDE Plasma Version: 6.0.2 KDE Frameworks Version: 6.0.0 Qt Version: 6.6.2 Graphics platform: Wayland Created attachment 168776 [details]
Calendar
I can confirm that this is also in Fedora KDE.
Now, how to tell in what condition the first week of a year starts, that I don't know how to check that. It might be a regional thing.
But there seems to be a discrepancy between the different KDE components, as in the following screenshot, the Plasma Calendar and Merkuro disagree:
Sorry for the big screenshot... I forgot to crop it before I posted and it seems Bugzilla's not allowing me to replace it. But ignore the Google search in the background; if you look at the screenshot, Merkuro shows Jan 7th -> 13th as being week 1 while the system calendar shows Dec 31st to Jan 6th as being Week 1. I happened to make a duplicate bug on redhat bugzilla for this, see: https://bugzilla.redhat.com/show_bug.cgi?id=2276317 (In reply to Steve Cossette from comment #3) > Sorry for the big screenshot... I forgot to crop it before I posted and it > seems Bugzilla's not allowing me to replace it. But ignore the Google search > in the background; if you look at the screenshot, Merkuro shows Jan 7th -> > 13th as being week 1 while the system calendar shows Dec 31st to Jan 6th as > being Week 1. Good catch. It appears system calendar is correct, and Merkuro is not. I don't think there is a way to adjust, so I guess that needs to be fixed in code. While the week number is off, I don't believe it's the root cause of this issue. If I change the week view to "Basic week view" in the Settings, the correct week is always shown. The bug seems to be in how SwipeableInternalHourlyView handles the visual representation of weeks. The correct week is stored, but its view model chooses the wrong "index". I can exacerbate the issue by doing the following: 1. Open a new instance of Merkuro Calendar. 2. Click Next Week. The week won't change. 3. Click Previous Week. The week still won't change. I was able to "resolve" that issue by modifying DateTimeState::firstDayOfWeek(), but it still starts on the wrong week. With the change, clicking "Now" properly moves to the expected week though, regardless of what week I'm on. A possibly relevant merge request was started @ https://invent.kde.org/pim/merkuro/-/merge_requests/442 I have noticed that after this merge request: https://invent.kde.org/pim/merkuro/-/merge_requests/442 hitting the "Now" button jumps back to the correct day, however: 1) Startup is still a week too late 2) The weeknumber is still wrong So it appears the program looks for the correct weeknumber, but since the weeknumbering is wrong it is consequently starts in the wrong week. |