Bug 482377

Summary:	When re-ordering pages in System Monitor, can't drag a page down; only up
Product:	[Applications] plasma-systemmonitor	Reporter:	Dashon <dashonwwIII>
Component:	general	Assignee:	KSysGuard Developers <ksysguard-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ahiemstra, dashonwwIII, nate, plasma-bugs
Priority:	NOR
Version:	6.0.0
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/8f590ae92e53fc8456fd360ca0491e0dde784f13	Version Fixed In:	6.0.3
Attachments:	System Monitor Edit Pages

Description Dashon 2024-03-04 12:41:02 UTC

SUMMARY
Testing plasma 6 using arch's testing repositories.
If I open system monitor and go to edit pages from view or the hamburger menu. Then I can not drag one page down. I can only drag other pages down. Also moving the pages up or down causes that item to essentially get stuck behind the first item.


STEPS TO REPRODUCE
1. Open system monitor
2. Go to view or the hamburger menu and click edit pages.
3. Try moving a page down.

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Dashon 2024-03-04 12:41:47 UTC

Created attachment 166395 [details]
System Monitor Edit Pages

Comment 2 Nate Graham 2024-03-05 19:41:12 UTC

Can reproduce.

Comment 3 Bug Janitor Service 2024-03-18 16:06:27 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/270

Comment 4 Arjen Hiemstra 2024-03-22 10:41:45 UTC

Git commit 212835b8581a9ce383c34c07baa24c384d2e1c4d by Arjen Hiemstra.
Committed on 22/03/2024 at 10:40.
Pushed by ahiemstra into branch 'master'.

page: Fix drag-sorting of pages in PageSortDialog

When using ListDragHandle, it shouldn't be the actual listview delegate
that's being dragged but an item inside it. In addition, also correct
some other porting issues.

M  +120  -115  src/page/PageSortDialog.qml

https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/212835b8581a9ce383c34c07baa24c384d2e1c4d

Comment 5 Arjen Hiemstra 2024-03-22 13:37:21 UTC

Git commit 8f590ae92e53fc8456fd360ca0491e0dde784f13 by Arjen Hiemstra.
Committed on 22/03/2024 at 13:35.
Pushed by ahiemstra into branch 'Plasma/6.0'.

page: Fix drag-sorting of pages in PageSortDialog

When using ListDragHandle, it shouldn't be the actual listview delegate
that's being dragged but an item inside it. In addition, also correct
some other porting issues.


(cherry picked from commit 212835b8581a9ce383c34c07baa24c384d2e1c4d)

M  +120  -115  src/page/PageSortDialog.qml

https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/8f590ae92e53fc8456fd360ca0491e0dde784f13