Bug 482032

Summary: Setting transition duration too high (400 minutes +) results in two suns being rendered
Product: [Applications] systemsettings Reporter: postix <postix>
Component: kcm_nightcolorAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: isma.af, kwin-bugs-null, nate
Priority: NOR Keywords: qt6
Version First Reported In: 5.93.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In: 6.0.1
Sentry Crash Report:
Attachments: Screenshot

Description postix 2024-02-29 14:38:20 UTC
Created attachment 166192 [details]
Screenshot

SUMMARY

Setting transition duration too high (400 minutes +) results in two suns being rendered

SOFTWARE/OS VERSIONS
Operating System: Fedora-KDE-Live-x86_64-Rawhide-20240229.n.0.iso
KDE Plasma Version: 6.0.0
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Kernel Version: 6.8.0-rc5
Graphics Platform: Wayland
Graphics Processor: SVGA3D; build; RELEASE; LLVM;
VirtualBox 7.0 on openSUSE TW
Captured Cursure; Windowed mode
Comment 1 postix 2024-02-29 14:41:23 UTC
Also if you use 
Begin Nightlight at 10 and
Being Day Light at 24 and
Duration = 1
you get two moons
Comment 2 guimarcalsilva 2024-02-29 23:33:25 UTC
Can confirm. The issue appears starting at 360 minutes
Comment 3 Bug Janitor Service 2024-03-02 17:03:06 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3995
Comment 4 Ismael Asensio 2024-03-03 12:40:15 UTC
Git commit f17f05433ad5b781ce784e89b8a3100b14ee3f19 by Ismael Asensio.
Committed on 03/03/2024 at 12:27.
Pushed by iasensio into branch 'master'.

kcms/nightcolor: Fix DayNightView on edge cases

Improve the DayNightView model for some edge cases where the
transition ends on the next day than it starts

- Hide the edge icon when a transition overflows
- Calculate better if the middle icon represents day or night
- Move the gradient stop for position 0 to the end of the list,
  to avoid other stops overriding it at the same position.
FIXED-IN: 6.0.1

M  +11   -5    kcms/nightcolor/ui/DayNightView.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/f17f05433ad5b781ce784e89b8a3100b14ee3f19
Comment 5 Ismael Asensio 2024-03-03 15:28:32 UTC
Git commit 096149c39fac116d5c392830b361641b9eaf9ac4 by Ismael Asensio.
Committed on 03/03/2024 at 15:06.
Pushed by iasensio into branch 'Plasma/6.0'.

kcms/nightcolor: Fix DayNightView on edge cases

Improve the DayNightView model for some edge cases where the
transition ends on the next day than it starts

- Hide the edge icon when a transition overflows
- Calculate better if the middle icon represents day or night
- Move the gradient stop for position 0 to the end of the list,
  to avoid other stops overriding it at the same position.
FIXED-IN: 6.0.1


(cherry picked from commit f17f05433ad5b781ce784e89b8a3100b14ee3f19)

M  +11   -5    kcms/nightcolor/ui/DayNightView.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/096149c39fac116d5c392830b361641b9eaf9ac4