Bug 481907

Summary: Kstars 3.6.9 - Dark Library - Clear Row button removing wrong row
Product: [Applications] kstars Reporter: Edoardo Zanoni <edoardo.zanoni+kde_bug>
Component: generalAssignee: Jasem Mutlaq <mutlaqja>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Debian stable   
OS: Linux   
Latest Commit: Version Fixed In: 3.7.0
Attachments: 01_second_row_selected
02_first_row_deleted

Description Edoardo Zanoni 2024-02-27 19:30:32 UTC
Created attachment 166143 [details]
01_second_row_selected

*SUMMARY*
When trying to delete a specific row in the dark masters' library using "Clear Row", the first row is deleted instead

*STEPS TO REPRODUCE*
1. Open the Darks button in the CCD menu
2. Create 2 darks
3. Goto "Masters" tab
4. Select the second row by double clicking it
5. Press "Clear Row"

*OBSERVED RESULT*
The first row is cleared (and it's relative file deleted) instead of the selected one.

*EXPECTED RESULT*
The second row and it's file get cancelled

*SOFTWARE/OS VERSIONS*
Application: kstars
Version: 3.6.9 Stable
Linux: Debian GNU/Linux 12 (bookworm) 12 (arm64)

*ADDITIONAL INFORMATION*
The problem was found in a previous version, so it's not a new bug introduced with version 3.6.9.
Cannot remember the first time the bug was seen
Comment 1 Edoardo Zanoni 2024-02-27 19:31:31 UTC
Created attachment 166144 [details]
02_first_row_deleted

Second image showcasing the bug
Comment 2 Jasem Mutlaq 2024-02-29 05:46:45 UTC
Git commit 19cc38071ca46d3df5626595bed40fe334394612 by Jasem Mutlaq.
Committed on 29/02/2024 at 05:46.
Pushed by mutlaqja into branch 'master'.

Fix issues with removing dark frames from table.
Related: bug 481908
FIXED-IN:3.7.0

M  +17   -22   kstars/ekos/auxiliary/darklibrary.cpp

https://invent.kde.org/education/kstars/-/commit/19cc38071ca46d3df5626595bed40fe334394612
Comment 3 Jasem Mutlaq 2024-03-03 04:54:48 UTC
Git commit 455591ec33a7f0bdae7574e3cc115b8a25424179 by Jasem Mutlaq.
Committed on 03/03/2024 at 04:53.
Pushed by mutlaqja into branch 'stable-3.6.9'.

Fix issues with removing dark frames from table.
Related: bug 481908
FIXED-IN:3.7.0

M  +17   -22   kstars/ekos/auxiliary/darklibrary.cpp

https://invent.kde.org/education/kstars/-/commit/455591ec33a7f0bdae7574e3cc115b8a25424179