Bug 481813

Summary: Adding a blank feed yields a broken unremovable feed
Product: [Applications] Alligator Reporter: Kacper Słomiński <kacper.slominski72>
Component: GeneralAssignee: Tobias Fella <fella>
Status: RESOLVED FIXED    
Severity: normal CC: isaac
Priority: NOR Keywords: qt6
Version First Reported In: 24.01.95   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: https://invent.kde.org/network/alligator/-/commit/944007bdc8df4a110cd06b54dc10400964fe0db1 Version Fixed/Implemented In:
Sentry Crash Report:

Description Kacper Słomiński 2024-02-25 14:52:01 UTC 
SUMMARY
Adding a new feed without filling in the feed URL leads to an unnamed, unremovable feed.

STEPS TO REPRODUCE
1. Go to "Manage Feeds",
2. Click on "Add Feed...",
3. Click on "Add Feed" without inputting a URL,
4. Press the trashcan icon next to the blank feed to try and remove it,
5. Switch to a different screen (e.g. "About") and back to "Manage Feeds" and observe how the feed is back.

OBSERVED RESULT
The feed persists no matter what I do.

EXPECTED RESULT
Alligator doesn't let you create a feed without a URL, or at least allows you to delete it.

SOFTWARE/OS VERSIONS
Linux: Gentoo Linux (with ::kde overlay)
KDE Plasma Version: 5.93.0
KDE Frameworks Version: 5.249.0
Qt Version: 6.6.2

ADDITIONAL INFORMATION
Regular feeds still work fine despite this, and they can be deleted properly. Switching from a normal feed to the blank feed pops up an error about an unsupported protocol "".
Comment 1 Isaac Patton 2024-11-06 01:56:13 UTC 
I can reproduce this error with Alligator built using kde-builder with an x86 target and tested on Fedora Linux and with Alligator built using Craft and tested on Android 14.
Comment 2 Bug Janitor Service 2024-11-06 19:58:05 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/network/alligator/-/merge_requests/110
Comment 3 Tobias Fella 2024-11-10 13:32:31 UTC 
Git commit 944007bdc8df4a110cd06b54dc10400964fe0db1 by Tobias Fella, on behalf of Isaac Patton.
Committed on 10/11/2024 at 13:32.
Pushed by tfella into branch 'master'.

Add validation to urlField in AddFeedDialog

urlField had no validation. Add validation to prevent empty string and whitespace.

M  +2    -0    src/qml/AddFeedDialog.qml

https://invent.kde.org/network/alligator/-/commit/944007bdc8df4a110cd06b54dc10400964fe0db1