Summary: | Clicking checkbox to select content to share does not work | ||
---|---|---|---|
Product: | [Plasma] xdg-desktop-portal-kde | Reporter: | Iyán Méndez Veiga <me> |
Component: | general | Assignee: | Nate Graham <nate> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | adam.m.fontenot+kde, aleixpol, gloriouseggroll, jgrulich, kde.quote035, luminoso, mashkal2000, mmbossoni, nate, nicolas.fella |
Priority: | NOR | Keywords: | qt6 |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/kirigami/-/commit/4a0bc5a89725407e800ce44c662e21e7f4a35d4f | Version Fixed In: | Frameworks 6.3 |
Attachments: | Running latest code from Plasma/6.0 branch |
Description
Iyán Méndez Veiga
2024-02-17 12:10:13 UTC
Here is a video of the issue: https://drive.switch.ch/index.php/s/DfhCU46JWp8oTtm This piece of code has received quite a bit of love over the last few weeks, can you try refreshing it? I notice your laptop output name still doesn't have the fix. Created attachment 165909 [details]
Running latest code from Plasma/6.0 branch
Still an issue on Plasma/6.0 branch. But yes, the laptop's screen now has a nice name :)
Cannot reproduce with current git master and Qt 6.6.0. or me, clicking on the checkboxes toggles the selection state of the cards as expected. Maybe a Qt 6.7 regression somehow? FWIW I couldn't even see the checkbox version of the dialog at all when invoking it from OBS; I had to fake it by adding a `root.multiple = true;` to the component.onCompleted handler in ScreenDialogChooser.qml. If anyone can offer any pointers on how to get the dialog into multi-selection mode in a production environment, I'd be grateful. *** Bug 482517 has been marked as a duplicate of this bug. *** I reproduced this just now on portal version 6.0.1 and Qt 6.6.2. Reproduction (two different ways): 1. Install Kooha, and use that to open the portal Screen Share window. 2. Use the Python snippet here: https://gitlab.gnome.org/-/snippets/19 Confirming on that basis. Operating System: Arch Linux KDE Plasma Version: 6.0.1 KDE Frameworks Version: 6.0.0 Qt Version: 6.6.2 Kernel Version: 6.7.9-arch1-1 (64-bit) Graphics Platform: Wayland Can reproduce with those. I'll investigate. Experiencing the same issue with KDE neon user edition 6.0. Clicking the checkbox does not enable the share button SOFTWARE/OS VERSIONS Operating System: KDE neon KDE Plasma Version: 6.0.3 KDE Frameworks Version: 6.0.0 Qt Version: 6.6.2 Kernel Version: 6.5.0-26-generic (64-bit) Graphics Platform: Wayland Out of curiosity I tested KDE neon Unstable Edition. The checkbox and the share button got fully removed there. SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 6.0.80 KDE Frameworks Version: 6.1.0 Qt Version: 6.6.2 Kernel Version: 6.5.0-26-generic (64-bit) Graphics Platform: Wayland *** Bug 485695 has been marked as a duplicate of this bug. *** Ok, I just adjusted our test app to sent "true" for the "multiple" flag and now I can test this case and reproduce the issue. Will fix it. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1561 That fixes it for me. The issue is obvious now. Git commit 4a0bc5a89725407e800ce44c662e21e7f4a35d4f by Nate Graham. Committed on 21/05/2024 at 19:36. Pushed by ngraham into branch 'master'. Card: emit toggled() when the user clicks on the header checkbox Checkable cards display a checkbox in the header. When clicked, they emit toggled() which gets bubbled up to the card. However the card doesn't emit the toggled() signal itself, instead only setting the value of its "checked" property. As a result, anything that's listening to the card for a toggled() signal will not get one. Such as, for example, the screen chooser portal code. Fix this by emitting the signal. FIXED-IN: 6.3 M +1 -0 src/controls/Card.qml https://invent.kde.org/frameworks/kirigami/-/commit/4a0bc5a89725407e800ce44c662e21e7f4a35d4f Is there any workaround to restore the greyed out button? never mind. the workaround is to click in the image :-) *** Bug 488508 has been marked as a duplicate of this bug. *** |