Summary: | Annotations made while in Rectangular Region overlay end up in the wrong place | ||
---|---|---|---|
Product: | [Applications] Spectacle | Reporter: | Nate Graham <nate> |
Component: | General | Assignee: | Noah Davis <noahadvs> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | kde |
Priority: | NOR | Keywords: | qt6, regression |
Version: | git-master | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/graphics/spectacle/-/commit/f309049a7dab26cfd673bb399480d3ed5825ec9c | Version Fixed In: | 24.05 |
Description
Nate Graham
2024-02-16 21:01:56 UTC
Unfortunately, I cannot reproduce this. I see you put the version as 23.04.1, but that's a mistake, right? When I tried reproducing this, I tried a few different screen configurations, always with two screens horizontally next to each other. 1. 1x, 2x 2. 1x, 1.75x 3. 1x, 2.25x 4. 1.25x, 2x. I tried drawing rectangles on both screens and they were always in the correct locations. That is a mistake, it's current git master. I just tried it with my dual-screen setup (4k@225% on the left, 1080p@110% on the right) and got the same result. Here's a video that shows it happening, in case my description was not clear enough. I couldn't attach it as I was unable to compress it enough to get it under the 4 MB size limit on Bugzilla. https://imgur.com/zr2utzN Ok, so I did not test actually cropping the rectangle screenshot. The problem occurs when I actually set a rectangular area to capture. Curiously, the problem only applies to the last annotation. Previous annotations are fine and the problem goes away if I undo and redo the last annotation. Greaṫ! But now I have to wonder: in what universe do you do a Rectangular Region screenshot and not drag a box around something? :D Isn't that the use case of Rectangular Region instead of Full Screen? (In reply to Nate Graham from comment #6) > Greaṫ! But now I have to wonder: in what universe do you do a Rectangular > Region screenshot and not drag a box around something? :D Isn't that the use > case of Rectangular Region instead of Full Screen? You can also capture all screens just by pressing enter with no selection. Git commit f309049a7dab26cfd673bb399480d3ed5825ec9c by Noah Davis. Committed on 05/04/2024 at 18:55. Pushed by ndavis into branch 'master'. Add backend logic for undoable cropping Also separate mousePath (interactive path) and visualRect from Traits::Geometry into Traits::Interactive and Traits::Visual. Needed to be able to have geometry without visibility or interactivity in a history item. M +99 -40 src/Gui/Annotations/AnnotationDocument.cpp M +7 -3 src/Gui/Annotations/AnnotationDocument.h M +10 -5 src/Gui/Annotations/AnnotationViewport.cpp M +6 -5 src/Gui/Annotations/EffectUtils.cpp M +143 -29 src/Gui/Annotations/Traits.cpp M +41 -13 src/Gui/Annotations/Traits.h https://invent.kde.org/graphics/spectacle/-/commit/f309049a7dab26cfd673bb399480d3ed5825ec9c |