Bug 481433

Summary: With System Settings' minimum window size, buttons in per-event notification UI can get pushed out of the frame
Product: [Applications] systemsettings Reporter: Nate Graham <nate>
Component: kcm_notifyAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: isma.af, kde
Priority: NOR Keywords: qt6
Version First Reported In: 5.93.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 6.0
Sentry Crash Report:
Attachments: Stuff cut off

Description Nate Graham 2024-02-16 20:58:12 UTC
Created attachment 165872 [details]
Stuff cut off

STEPS TO REPRODUCE
Open System Settings > Notifications > Application-Specific Settings: Configure > Discover > click on "Failed offline Update"


OBSERVED RESULT
The "Play a sound" row's contents are too wide, causing the entire delegate's right side UI elements to get pushed out of the window. See attached screenshot.
Comment 1 Bug Janitor Service 2024-02-16 22:11:07 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3916
Comment 2 Ismael Asensio 2024-02-16 23:20:01 UTC
Git commit 761eb760023315ba280a14676d182e935db4ffd8 by Ismael Asensio.
Committed on 16/02/2024 at 21:50.
Pushed by iasensio into branch 'master'.

kcms/notifications: Fix delegate's minimum size

The RowLayout within the delegate will not shrink below its
content's implicit width, even when it overflows the external
width constraint.

We can use some Layout properties in a creative way to reduce
this, so that the TextField can shrink but keeps its regular
size when the space available is wider.
FIXED-IN: 6.0

M  +5    -0    kcms/notifications/ui/ApplicationConfiguration.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/761eb760023315ba280a14676d182e935db4ffd8
Comment 3 Ismael Asensio 2024-02-16 23:45:40 UTC
Git commit 879de1b4cc9a5011f325cc564ac9c19754841194 by Ismael Asensio.
Committed on 16/02/2024 at 23:22.
Pushed by iasensio into branch 'Plasma/6.0'.

kcms/notifications: Fix delegate's minimum size

The RowLayout within the delegate will not shrink below its
content's implicit width, even when it overflows the external
width constraint.

We can use some Layout properties in a creative way to reduce
this, so that the TextField can shrink but keeps its regular
size when the space available is wider.
FIXED-IN: 6.0


(cherry picked from commit 761eb760023315ba280a14676d182e935db4ffd8)

M  +5    -0    kcms/notifications/ui/ApplicationConfiguration.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/879de1b4cc9a5011f325cc564ac9c19754841194