| Summary: | Edge trigger (hot corner) for Overview effect cycles between Overview and "Grid View", with no way to change this | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Adam Fontenot <adam.m.fontenot+kde> |
| Component: | effects-overview | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | fanzhuyifan, kurnevsky, nate |
| Priority: | NOR | Keywords: | qt6, usability |
| Version First Reported In: | 5.93.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/-/commit/d26d95ed3bd95f7dd426f5a4785b18e3e4b249a3 | Version Fixed/Implemented In: | 6.1 |
| Sentry Crash Report: | |||
|
Description
Adam Fontenot
2024-02-14 19:22:20 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/5213 Can confirm, yeah. This is a bit awkward. Git commit fc92544cb3530ecf60aa110339b5e198b25f9301 by Vlad Zahorodnii. Committed on 16/02/2024 at 08:59. Pushed by vladz into branch 'master'. plugins/overview: Allow switching between modes using shortcuts while already active Overview and Grid modes have shortcuts assigned to them. While they provide a way to toggle the overview effect between on and off state, in other words overview <-> off or grid <-> off, it's not possible to move between the modes by pressing those shortcuts, e.g. off -> overview -> grid -> overview -> grid -> ... -> off. The culprit seems to be that EffectTogglableState has two "inactive" states - Inactive and Stopped. It's counter-intuitive and needs a further cleanup. To make switching between overview modes work, this change makes EffectTogglableState::toggle() toggle the state based on the Active state. There's only one active state. M +1 -1 src/effect/effecttogglablestate.cpp https://invent.kde.org/plasma/kwin/-/commit/fc92544cb3530ecf60aa110339b5e198b25f9301 A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/5221 Git commit 58f33b03a261c099c999951bb892a77db1b92826 by Vlad Zahorodnii. Committed on 16/02/2024 at 09:06. Pushed by vladz into branch 'Plasma/6.0'. plugins/overview: Allow switching between modes using shortcuts while already active Overview and Grid modes have shortcuts assigned to them. While they provide a way to toggle the overview effect between on and off state, in other words overview <-> off or grid <-> off, it's not possible to move between the modes by pressing those shortcuts, e.g. off -> overview -> grid -> overview -> grid -> ... -> off. The culprit seems to be that EffectTogglableState has two "inactive" states - Inactive and Stopped. It's counter-intuitive and needs a further cleanup. To make switching between overview modes work, this change makes EffectTogglableState::toggle() toggle the state based on the Active state. There's only one active state. (cherry picked from commit fc92544cb3530ecf60aa110339b5e198b25f9301) M +1 -1 src/effect/effecttogglablestate.cpp https://invent.kde.org/plasma/kwin/-/commit/58f33b03a261c099c999951bb892a77db1b92826 A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/5222 Git commit f77f5b234256af9b22b1852364dcedd05d1d9d6f by Vlad Zahorodnii. Committed on 21/02/2024 at 08:44. Pushed by vladz into branch 'master'. plugins/overview: Make screen edge toggle overview rather than cycle between modes The user may have no usecase for the grid view mode, i.e. they may want to activate overview, do their thing, and then return back to normal desktop. However, with the current behavior, there's one extra step (switch to grid mode) in order to go back to desktop. In hindsight, we should have added different screen edge actions for overview and grid modes. This can be done in 6.1. M +1 -1 src/plugins/overview/overvieweffect.cpp https://invent.kde.org/plasma/kwin/-/commit/f77f5b234256af9b22b1852364dcedd05d1d9d6f Git commit d26d95ed3bd95f7dd426f5a4785b18e3e4b249a3 by Vlad Zahorodnii. Committed on 21/02/2024 at 10:06. Pushed by vladz into branch 'Plasma/6.0'. plugins/overview: Make screen edge toggle overview rather than cycle between modes The user may have no usecase for the grid view mode, i.e. they may want to activate overview, do their thing, and then return back to normal desktop. However, with the current behavior, there's one extra step (switch to grid mode) in order to go back to desktop. In hindsight, we should have added different screen edge actions for overview and grid modes. This can be done in 6.1. (cherry picked from commit f77f5b234256af9b22b1852364dcedd05d1d9d6f) M +1 -1 src/plugins/overview/overvieweffect.cpp https://invent.kde.org/plasma/kwin/-/commit/d26d95ed3bd95f7dd426f5a4785b18e3e4b249a3 > In hindsight, we should have added different screen edge actions for
> overview and grid modes. This can be done in 6.1.
Is there an issue for that? I'd really like to have grid mode available from hot corner - I always used it but now it's not available.
We already added it. It will be available in 6.1 Do you mind specifying the commit/MR? I'd probably like to backport it to 6.0 for myself :) I think I found it: https://invent.kde.org/plasma/kwin/-/merge_requests/5298 |