Summary: | Desktop files/folders dropped from one screen onto another one disappear until plasmashell is restarted or the other screen is disconnected/reconnected | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | groomyrocky |
Component: | Folder | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | dashonwwIII, dougshaw77, hein, nate, postix |
Priority: | VHI | Keywords: | multiscreen, qt6 |
Version: | 5.93.0 | ||
Target Milestone: | 1.0 | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/-/commit/e306c63ddbeaccea72a03fbb2c3dbd8245addef5 | Version Fixed In: | 6.0.1 |
Description
groomyrocky
2024-02-12 09:26:52 UTC
Can reproduce. Icons don't have to be there during upgrade to KDE6. You can add icons and move them and reproduce. Operating System: KDE neon Testing Edition KDE Plasma Version: 6.0.0 KDE Frameworks Version: 6.0.0 Qt Version: 6.6.1 Kernel Version: 6.5.0-18-generic (64-bit) Graphics Platform: Wayland Graphics Processor: AMD Radeon Pro WX 3200 Series Aaaaa can reproduce If I restart plasmashell, the file appears on the external screen in the position I dragged it to. If instead, I disconnect the screen that I dragged the file onto, it re-appears on the original screen, but in the top-left-most position, not where it was before. If I then re-connect the external screen, the file appears on its desktop in the top-left-most position. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2069 Git commit f0ede2d83731952012be0d43c77916d18617edb2 by Marco Martin. Committed on 28/02/2024 at 08:49. Pushed by mart into branch 'master'. FolderView Positioner: fix rows insert and remove The positioner "proxy" model had problems both in rows insertion and removal. when an icon is dropped in an empty desktop area as the new "last" position, the positioner model creates new empty items for the GridView until it reaches the cell of the drop position. This broke because of connection slot invocation order: the connection to QAbstractItemModel::rowsInserted in FolderModel constructor was executed before the connection in positioner. In turn that connection emitted move, which invoked move on Positioner, which at this point thinks its still in the first rows insertion transaction, because its slot has not been executed yet, and m_beginInsertRowsCalled is still true, so there won't be a "correct" new beginInsertRows called. Make it a Queued connection to push it back. In the same way, when dragging from a "last" position, the Positioner model will remove all the trailing empty items. But it modified m_proxyToSource (from which rowCount() depends) before calling beginRemoveRows, sending the model into an inconsitent state and causing an assert. Make sure that m_proxyToSource is touched only after beginRemoveRows. Related: bug 466337 M +18 -11 containments/desktop/plugins/folder/foldermodel.cpp M +11 -6 containments/desktop/plugins/folder/positioner.cpp https://invent.kde.org/plasma/plasma-desktop/-/commit/f0ede2d83731952012be0d43c77916d18617edb2 Git commit e306c63ddbeaccea72a03fbb2c3dbd8245addef5 by Marco Martin. Committed on 28/02/2024 at 08:50. Pushed by mart into branch 'Plasma/6.0'. FolderView Positioner: fix rows insert and remove The positioner "proxy" model had problems both in rows insertion and removal. when an icon is dropped in an empty desktop area as the new "last" position, the positioner model creates new empty items for the GridView until it reaches the cell of the drop position. This broke because of connection slot invocation order: the connection to QAbstractItemModel::rowsInserted in FolderModel constructor was executed before the connection in positioner. In turn that connection emitted move, which invoked move on Positioner, which at this point thinks its still in the first rows insertion transaction, because its slot has not been executed yet, and m_beginInsertRowsCalled is still true, so there won't be a "correct" new beginInsertRows called. Make it a Queued connection to push it back. In the same way, when dragging from a "last" position, the Positioner model will remove all the trailing empty items. But it modified m_proxyToSource (from which rowCount() depends) before calling beginRemoveRows, sending the model into an inconsitent state and causing an assert. Make sure that m_proxyToSource is touched only after beginRemoveRows. Related: bug 466337 M +18 -11 containments/desktop/plugins/folder/foldermodel.cpp M +11 -6 containments/desktop/plugins/folder/positioner.cpp https://invent.kde.org/plasma/plasma-desktop/-/commit/e306c63ddbeaccea72a03fbb2c3dbd8245addef5 I seem to be once again having this issue on plasma 6. I'm using arch's testing repositories, so that may be the issue. Can anyone confirm that there haven't been any regressions? Sorry, I didn't check the date. The solution was rather recent and most likely isn't in a current release yet. My apologies for reopening this. It is fixed in 6.0.1, although I do see it briefly appear on the previous monitor before jumping to the monitor that you dragged it to. I'll file a different report for that though. |