| Summary: | Segfault when adding new File Association | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | akhtaboot |
| Component: | kcm_filetypes | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | faure, nate |
| Priority: | NOR | Keywords: | drkonqi, qt6 |
| Version: | 5.93.0 | ||
| Target Milestone: | --- | ||
| Platform: | NixOS | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kde-cli-tools/-/commit/7c0f78f045beea968ca7ebbd35b1d1414a22761d | Version Fixed In: | 6.0 |
| Sentry Crash Report: | |||
|
Description
akhtaboot
2024-02-11 15:09:12 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kde-cli-tools/-/merge_requests/103 Git commit c099d4b08b5efd96e5748ba905fe2cddcada07fd by Harald Sitter. Committed on 11/02/2024 at 21:09. Pushed by sitter into branch 'master'. keditfiletype: fix crash when adding apps to "empty" views thou shalt not c-cast => let's dynamic cast, through dynamic cast we'll notice that the items aren't actually what we thought they should be and then we can skip them. notably when there is no app association we insert a fake 'None' entry, this entry is still present when updatePreferredServices runs but needs skipping because it does not represent a service I should note that the UX for the new-association use case is fairly buggy still, but at least it doesn't crash M +10 -3 keditfiletype/kservicelistwidget.cpp https://invent.kde.org/plasma/kde-cli-tools/-/commit/c099d4b08b5efd96e5748ba905fe2cddcada07fd Git commit 7c0f78f045beea968ca7ebbd35b1d1414a22761d by Harald Sitter. Committed on 12/02/2024 at 17:08. Pushed by sitter into branch 'Plasma/6.0'. keditfiletype: fix crash when adding apps to "empty" views thou shalt not c-cast => let's dynamic cast, through dynamic cast we'll notice that the items aren't actually what we thought they should be and then we can skip them. notably when there is no app association we insert a fake 'None' entry, this entry is still present when updatePreferredServices runs but needs skipping because it does not represent a service I should note that the UX for the new-association use case is fairly buggy still, but at least it doesn't crash (cherry picked from commit c099d4b08b5efd96e5748ba905fe2cddcada07fd) M +10 -3 keditfiletype/kservicelistwidget.cpp https://invent.kde.org/plasma/kde-cli-tools/-/commit/7c0f78f045beea968ca7ebbd35b1d1414a22761d |