| Summary: | Alternate calendar and holidays can't be selected | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Hirad <redstar> |
| Component: | Digital Clock widget | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | nate, nicolas.fella, qydwhotmail |
| Priority: | NOR | Keywords: | qt6, regression |
| Version First Reported In: | 5.93.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/28ab381a3347249532fce3645d380a0e5875ac61 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | screenshot of digital clock settings | ||
|
Description
Hirad
2024-02-01 10:07:27 UTC
Can reproduce. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3848 Git commit b7d3a7cce53ad8b3bfd5b3a2a7b4c5194086f844 by Nicolas Fella. Committed on 01/02/2024 at 22:15. Pushed by nicolasfella into branch 'master'. [applets/digitalclock] Fix resolving config UI file It resolves this based on the plugin name, that used to be the absolute path but is now only the id Adjust the code accordingly and retrive the value earlier where we still have the file name at hand M +5 -7 components/calendar/eventpluginsmanager.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/b7d3a7cce53ad8b3bfd5b3a2a7b4c5194086f844 Git commit 28ab381a3347249532fce3645d380a0e5875ac61 by Nicolas Fella. Committed on 02/02/2024 at 01:09. Pushed by nicolasfella into branch 'Plasma/6.0'. [applets/digitalclock] Fix resolving config UI file It resolves this based on the plugin name, that used to be the absolute path but is now only the id Adjust the code accordingly and retrive the value earlier where we still have the file name at hand (cherry picked from commit b7d3a7cce53ad8b3bfd5b3a2a7b4c5194086f844) M +5 -7 components/calendar/eventpluginsmanager.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/28ab381a3347249532fce3645d380a0e5875ac61 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3854 Git commit 3b23cf4bf42a27ff6d73b825cc87ad31b9661a22 by Fushan Wen. Committed on 03/02/2024 at 04:22. Pushed by fusionfuture into branch 'master'. appiumtests/digitalclocktest: test calendar plugin config ui works The config ui was omitted when porting the calendar plugin. Add a test to ensure it works in the future. M +10 -2 appiumtests/digitalclocktest.py M +5 -0 applets/digital-clock/package/contents/ui/configCalendar.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/3b23cf4bf42a27ff6d73b825cc87ad31b9661a22 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3855 Git commit df51bec8937b2698fb8b6a8f88b33a093548060b by Fushan Wen. Committed on 03/02/2024 at 04:37. Pushed by fusionfuture into branch 'Plasma/6.0'. appiumtests/digitalclocktest: test calendar plugin config ui works The config ui was omitted when porting the calendar plugin. Add a test to ensure it works in the future. (cherry picked from commit 3b23cf4bf42a27ff6d73b825cc87ad31b9661a22) M +10 -2 appiumtests/digitalclocktest.py M +5 -0 applets/digital-clock/package/contents/ui/configCalendar.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/df51bec8937b2698fb8b6a8f88b33a093548060b |