| Summary: | Wine 9 Wayland cursor does not hide when holding mouse button on game world to move camera/character | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Yao Mitachi <yaomtc> |
| Component: | wayland-generic | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version: | 5.27.10 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/-/commit/7644499e20280fd7cf99b2bb1424fc38f021ccd6 | Version Fixed In: | 6.0 |
| Sentry Crash Report: | |||
|
Description
Yao Mitachi
2024-01-31 03:55:05 UTC
Hmm video games won't start on my machine when running with wine+wayland. Do you know if any other applications or video games are affected by this issue? Also are you able to test Plasma 6? It had a few changes related to how cursor is handled > Hmm video games won't start on my machine when running with wine+wayland
DISPLAY= winecfg, works fine, just not video games...
Just tested Plasma 6, no difference there.
I did find one thing though, which I didn't test before. The cursor does hide when set in-game to Software Cursor. The issue only occurs when using either Hardware Cursor option ("FFXIV Custom" or "OS Standard". So if you don't mind slightly higher cursor latency and are particularly bothered by the cursor staying on screen (I'm not) this can be a workaround.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/5158 Git commit 13e7cac019fcb9825a3e2f1655622cf393e438ab by Vlad Zahorodnii. Committed on 09/02/2024 at 11:53. Pushed by vladz into branch 'master'. Handle wl_surface destruction in SurfaceCursorSource Wine/Wayland hides the cursor as follows: [ 853107.473] -> wl_pointer@15.set_cursor(172832, wl_surface@38, 0, 0) ... [ 858989.757] -> wl_surface@38.destroy() [ 858989.759] -> wl_pointer@15.set_cursor(172832, nil, 0, 0) i.e. it destroys the cursor surface, then calls wl_pointer.set_cursor(). SurfaceCursorSource stores the wl_surface in a QPointer, furthermore it is going to emit the changed signal, which is needed to force the CursorItem to update its content, only if either a new hotspot or a surface has been passed to SurfaceCursorSource::update(). So what happens is the following: - The SurfaceInterface object is destroyed and the QPointer resets its value to nullptr - SurfaceCursorSource::update(nullptr, QPointF(0, 0)) gets called in response to wl_pointer@15.set_cursor(nil, 0, 0) - but since m_surface has been implicitly reset to nullptr, no changed signal is going to be emitted This change addresses the issue by making the SurfaceCursorSource track the SurfaceInterface's destroyed signal. M +10 -0 src/cursorsource.cpp M +2 -2 src/cursorsource.h https://invent.kde.org/plasma/kwin/-/commit/13e7cac019fcb9825a3e2f1655622cf393e438ab Git commit 7644499e20280fd7cf99b2bb1424fc38f021ccd6 by Vlad Zahorodnii. Committed on 09/02/2024 at 12:08. Pushed by vladz into branch 'Plasma/6.0'. Handle wl_surface destruction in SurfaceCursorSource Wine/Wayland hides the cursor as follows: [ 853107.473] -> wl_pointer@15.set_cursor(172832, wl_surface@38, 0, 0) ... [ 858989.757] -> wl_surface@38.destroy() [ 858989.759] -> wl_pointer@15.set_cursor(172832, nil, 0, 0) i.e. it destroys the cursor surface, then calls wl_pointer.set_cursor(). SurfaceCursorSource stores the wl_surface in a QPointer, furthermore it is going to emit the changed signal, which is needed to force the CursorItem to update its content, only if either a new hotspot or a surface has been passed to SurfaceCursorSource::update(). So what happens is the following: - The SurfaceInterface object is destroyed and the QPointer resets its value to nullptr - SurfaceCursorSource::update(nullptr, QPointF(0, 0)) gets called in response to wl_pointer@15.set_cursor(nil, 0, 0) - but since m_surface has been implicitly reset to nullptr, no changed signal is going to be emitted This change addresses the issue by making the SurfaceCursorSource track the SurfaceInterface's destroyed signal. (cherry picked from commit 13e7cac019fcb9825a3e2f1655622cf393e438ab) M +10 -0 src/cursorsource.cpp M +2 -2 src/cursorsource.h https://invent.kde.org/plasma/kwin/-/commit/7644499e20280fd7cf99b2bb1424fc38f021ccd6 Can confirm that fixed the issue with the FFXIV cursor, thank you! |