Bug 480424

Summary: Untranslated string upon applet launch
Product: [Plasma] kdeplasma-addons Reporter: Emir SARI <emir_sari>
Component: WeatherAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: nate
Priority: NOR Keywords: qt6
Version: master   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: Version Fixed In: 6.0
Attachments: screenshot

Description Emir SARI 2024-01-28 10:22:39 UTC
Created attachment 165302 [details]
screenshot

See screenshot. Upon adding the widget, the "Configure..." button looks like it's not available for translation.
Comment 1 Nate Graham 2024-02-06 23:36:18 UTC
Can you add a new Comic Strip widget and see whether it also has an untranslated Configure button? If so, then this isn't an applet-specific issue, but rather a deeper one caused by whatever created that button either not making its text translated, or else specifying the wrong (or no) translation catalog for it to be loaded from.
Comment 2 Bug Janitor Service 2024-02-07 13:36:55 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2028
Comment 3 Emir SARI 2024-02-07 14:30:44 UTC
Git commit 8aebe3f54874af2b6ca61cbd1a1fd3fabca00c71 by Emir SARI.
Committed on 07/02/2024 at 13:36.
Pushed by esari into branch 'master'.

Fix i18n domain

M  +5    -5    containments/panel/contents/ui/ConfigOverlay.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/8aebe3f54874af2b6ca61cbd1a1fd3fabca00c71
Comment 4 Emir SARI 2024-02-10 14:59:11 UTC
I think this is the correct place: https://invent.kde.org/plasma/plasma-workspace/-/blob/master/components/containmentlayoutmanager/qml/BasicAppletContainer.qml#L270

The previous fix did not work. What's the correct domain for the above string?
Comment 5 Bug Janitor Service 2024-02-11 09:13:25 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3888
Comment 6 Emir SARI 2024-02-12 10:32:01 UTC
Git commit 2eab616a5340af6c36519bc4a8bb51843e9f93d6 by Emir SARI.
Committed on 12/02/2024 at 10:31.
Pushed by esari into branch 'master'.

Fix i18n

M  +1    -1    components/containmentlayoutmanager/qml/BasicAppletContainer.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/2eab616a5340af6c36519bc4a8bb51843e9f93d6
Comment 7 Emir SARI 2024-02-12 10:54:34 UTC
Git commit 19f9a9762d024f25ba6a9f0ae03ac8c451e69666 by Emir SARI.
Committed on 12/02/2024 at 10:32.
Pushed by esari into branch 'Plasma/6.0'.

Fix i18n

(cherry picked from commit 2eab616a5340af6c36519bc4a8bb51843e9f93d6)

M  +1    -1    components/containmentlayoutmanager/qml/BasicAppletContainer.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/19f9a9762d024f25ba6a9f0ae03ac8c451e69666