| Summary: | System Monitor widget's bars have a white background with Breeze Dark | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Ilya Bizyaev <bizyaev> |
| Component: | Theme - Breeze | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | dougshaw77, nate, visual-bugs-null |
| Priority: | NOR | Keywords: | qt6 |
| Version First Reported In: | 5.92.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/libksysguard/-/commit/10d51f8f637bae322b018fe00951508f59a123ec | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | Screenshot of the issue | ||
(In reply to Ilya Bizyaev from comment #0) > Created attachment 165296 [details] > Screenshot of the issue > > SUMMARY > Unlike Plasma 5 and previous pre-releases of Plasma 6, the background of > bars in System Monitor's widget is now white or light-gray, as opposed to > dark-gray. I'm assuming it's not an intentional change. > > > STEPS TO REPRODUCE > 1. Add a System Monitor widget to the panel. > 2. Configure it with “Horizontal Bars”. > > OBSERVED RESULT > See the attached screenshot. > > EXPECTED RESULT > The bars are of a less striking color. > > SOFTWARE/OS VERSIONS > Operating System: openSUSE Tumbleweed 20240126 > KDE Plasma Version: 6.0.80 > KDE Frameworks Version: 5.249.0 > Qt Version: 6.6.1 > Graphics Platform: Wayland > > ADDITIONAL INFORMATION Yeah, it sticks out like a sore thumb. Something like the dark background "track" or "groove" of the pie chart would look better. Vertical bars has no "track" background at all, but a scale instead. Can confirm. Interestingly for me the background is black with the Breeze Light color scheme; maybe some condition is simply inverted somewhere? A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/327 Git commit f06ce6222c41c7c43b044dfd37f68cc27fb5aeed by Arjen Hiemstra. Committed on 04/03/2024 at 09:53. Pushed by ahiemstra into branch 'master'. faces/horizontalbars: Use a fixed background rather than relying on style The bars end up potentially being used in two separate styles, either Plasma's styling or Desktop styling. This means we cannot rely on the style for our background as it would be wrong in one of the two contexts. So just hardcode a simple background that matches what we do for Pie charts. M +7 -2 faces/facepackages/horizontalbars/contents/ui/Bar.qml https://invent.kde.org/plasma/libksysguard/-/commit/f06ce6222c41c7c43b044dfd37f68cc27fb5aeed Git commit 10d51f8f637bae322b018fe00951508f59a123ec by Arjen Hiemstra. Committed on 20/03/2024 at 10:42. Pushed by ahiemstra into branch 'Plasma/6.0'. faces/horizontalbars: Use a fixed background rather than relying on style The bars end up potentially being used in two separate styles, either Plasma's styling or Desktop styling. This means we cannot rely on the style for our background as it would be wrong in one of the two contexts. So just hardcode a simple background that matches what we do for Pie charts. (cherry picked from commit f06ce6222c41c7c43b044dfd37f68cc27fb5aeed) M +7 -2 faces/facepackages/horizontalbars/contents/ui/Bar.qml https://invent.kde.org/plasma/libksysguard/-/commit/10d51f8f637bae322b018fe00951508f59a123ec |
Created attachment 165296 [details] Screenshot of the issue SUMMARY Unlike Plasma 5 and previous pre-releases of Plasma 6, the background of bars in System Monitor's widget is now white or light-gray, as opposed to dark-gray. I'm assuming it's not an intentional change. STEPS TO REPRODUCE 1. Add a System Monitor widget to the panel. 2. Configure it with “Horizontal Bars”. OBSERVED RESULT See the attached screenshot. EXPECTED RESULT The bars are of a less striking color. SOFTWARE/OS VERSIONS Operating System: openSUSE Tumbleweed 20240126 KDE Plasma Version: 6.0.80 KDE Frameworks Version: 5.249.0 Qt Version: 6.6.1 Graphics Platform: Wayland ADDITIONAL INFORMATION