Bug 480398

Summary: Project corrupt after duplicate sequence
Product: [Applications] kdenlive Reporter: red_Arti <jijiliu35>
Component: User Interface & MiscellaneousAssignee: Jean-Baptiste Mardelle <jb>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: git-master   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: duplicate-sequence-project-corrupt
corrupted-project

Description red_Arti 2024-01-27 16:32:38 UTC
Created attachment 165275 [details]
duplicate-sequence-project-corrupt

SUMMARY
(watch the screen record video I uploaded)


STEPS TO REPRODUCE
1. Create project
2. Drag Sequence 1 out of "Sequences" folder (important)
3. Delete "Sequences" folder (important)
4. Create title clip t. Add text in it
5. Add t to seq1
6. Create seq2
7. Add t to seq2
8. Create seq3
9. Add seq1 and seq2 into seq3
10. Duplicate seq3
11. Save
12. Quit Kdenlive. 
13. Open the saved project

OBSERVED RESULT
It says:
Errors found when opening project file (Sun Jan 28 00:15:57 2024)
A1 00:00:14:17 Timeline clip (tractor17) without bin reference found and removed.

Clips in Sequence 3 (copy) are messed

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Recent git branch 23.08 CI build 7314 AppImage Qt5 

ADDITIONAL INFORMATION
Comment 1 red_Arti 2024-01-27 16:33:34 UTC
Created attachment 165276 [details]
corrupted-project
Comment 2 red_Arti 2024-01-28 12:44:26 UTC
Found simpler steps to reproduce:
1. Create project
2. Drag Sequence 1 out of "Sequences" folder (important)
3. Delete "Sequences" folder (important)
4. Create a title clip (no content) . Add it to Seq1
5. Create Seq2
6. Add Seq1 into Seq2
7. Duplicate Seq2
8. Save, Close, Reopen

Error message:
tractor13 not found

To reproduce the bug, deleting "Sequences" folder is needed
Comment 3 red_Arti 2024-01-28 12:45:14 UTC
Another interesting thing:
1. Open any saved project
2. Duplicate any sequence in that project
3. Menu File -> "Save" is gray!!
Comment 4 Jean-Baptiste Mardelle 2024-01-30 18:54:07 UTC
Git commit 4ae7c24d5936652b94de187edf28d21457b7f21a by Jean-Baptiste Mardelle.
Committed on 30/01/2024 at 09:53.
Pushed by mardelle into branch 'release/24.02'.

Fix duplicate sequence not creating undo entry

M  +1    -0    src/bin/bin.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/4ae7c24d5936652b94de187edf28d21457b7f21a
Comment 5 Jean-Baptiste Mardelle 2024-01-31 12:33:07 UTC
Git commit bad2ff7babc8e50d097c44b5f839b852f279a1a7 by Jean-Baptiste Mardelle.
Committed on 31/01/2024 at 12:27.
Pushed by mardelle into branch 'release/24.02'.

Fix possible sequence corruption

M  +1    -0    src/bin/projectitemmodel.cpp
M  +9    -5    src/timeline2/model/builders/meltBuilder.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/bad2ff7babc8e50d097c44b5f839b852f279a1a7
Comment 6 Jean-Baptiste Mardelle 2024-02-12 08:04:37 UTC
Git commit f8558885255594caa5420f1f23d984b61c273305 by Jean-Baptiste Mardelle.
Committed on 12/02/2024 at 07:48.
Pushed by mardelle into branch 'release/23.08'.

Fix possible sequence corruption

M  +9    -5    src/timeline2/model/builders/meltBuilder.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/f8558885255594caa5420f1f23d984b61c273305