Bug 480358

Summary: It is not possible to create a tag from a split or transaction
Product: [Applications] kmymoney Reporter: Ralf Habacker <ralf.habacker>
Component: generalAssignee: KMyMoney Devel Mailing List <kmymoney-devel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: git (master)   
Target Milestone: ---   
Platform: Other   
OS: All   
Latest Commit: Version Fixed In: 5.2
Sentry Crash Report:
Attachments: test file
Screenshot from version 5.1.3 shows how to add tags in the Split Editor

Description Ralf Habacker 2024-01-26 14:17:26 UTC
Created attachment 165244 [details]
test file

SUMMARY
It is not possible to create a tag from a split. 


STEPS TO REPRODUCE
1. start kmymoney
2. open the appended file
3. open bank account and add a transaction
4. choose category1 and enter an amount
5. enter a character string in the tag field that does not correspond to an existing tag
6. save the transaction


OBSERVED RESULT
kmymoney does not recognize that a tag has been entered, but simply ignores it silently and leaves the user in the dark about it.

EXPECTED RESULT
In this case, kmymoney should ask whether a new tag should be created and proceed accordingly 

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSUSE Leap 15.5
KDE Frameworks Version: 5.103
Qt Version: 5.15

ADDITIONAL INFORMATION
Comment 1 Ralf Habacker 2024-01-30 09:25:08 UTC
Created attachment 165342 [details]
Screenshot from version 5.1.3 shows how to add tags in the Split Editor

This works with version 5.1.3 and should be fixed in the master branch to maintain usability.
Comment 2 Thomas Baumgart 2024-01-30 11:33:25 UTC
Git commit 83881a8d8b6ce20b8590125d53ec0d4af92e9885 by Thomas Baumgart.
Committed on 30/01/2024 at 11:09.
Pushed by tbaumgart into branch 'master'.

Add feature to create tags while editing
FIXED-IN: 5.2

M  +1    -0    kmymoney/dialogs/CMakeLists.txt
M  +3    -1    kmymoney/kmymoneyutils.cpp
M  +1    -1    kmymoney/kmymoneyutils.h
M  +6    -3    kmymoney/views/ktagsview.cpp
M  +20   -0    kmymoney/views/newspliteditor.cpp
M  +4    -0    kmymoney/views/newtransactioneditor.cpp
M  +27   -0    kmymoney/views/transactioneditorbase.cpp
M  +18   -0    kmymoney/views/transactioneditorbase.h
M  +25   -24   kmymoney/widgets/ktagcontainer.cpp
M  +1    -0    kmymoney/widgets/ktagcontainer.h

https://invent.kde.org/office/kmymoney/-/commit/83881a8d8b6ce20b8590125d53ec0d4af92e9885