Bug 480348

Summary:	Adjusting video with grouped subtitle can cause subtitle start position later than end position
Product:	[Applications] kdenlive	Reporter:	red_Arti <jijiliu35>
Component:	User Interface & Miscellaneous	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	git-master
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	https://invent.kde.org/multimedia/kdenlive/-/commit/57721eb6ef4a5772f688757ff80cec1ca8f8bd2f	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	screen-record

Description red_Arti 2024-01-26 01:48:23 UTC

Created attachment 165226 [details]
screen-record

SUMMARY
Drag and adjust video's start position, with grouped subtitle. Could cause subtitle start position later than end position

STEPS TO REPRODUCE
1. Use attachment project from https://bugs.kde.org/show_bug.cgi?id=480316, which contains subtitle with video clip grouped, and a subtitle's start position same as video start position
2. Drag and adjust video's start position. Drag to the right. 
Bug 1: Subtitle's start positions follows video, then start position become later than end position.
3. Bug 2: Then drag video back to the left, but when mouse up, the subtitle come back, but video clip fail to come back


OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Tested with:
1. Kdenlive latest git branch 23.08 ci build AppImage
2. Kdenlive git master ci build AppImage

ADDITIONAL INFORMATION

Comment 1 Jean-Baptiste Mardelle 2024-01-26 09:39:46 UTC

Git commit 7a56275032b3c1de3d1845f5e9b8681dcc047f6b by Jean-Baptiste Mardelle.
Committed on 26/01/2024 at 10:39.
Pushed by mardelle into branch 'release/24.02'.

Group resize: don't allow resizing a clip to length < 1

M  +4    -0    src/timeline2/model/timelinemodel.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/7a56275032b3c1de3d1845f5e9b8681dcc047f6b

Comment 2 Jean-Baptiste Mardelle 2024-01-26 09:41:06 UTC

Git commit 641c89e8a8bfeabc99f255b2a0a22e683295c8e2 by Jean-Baptiste Mardelle.
Committed on 26/01/2024 at 10:40.
Pushed by mardelle into branch 'release/23.08'.

Group resize: don't allow resizing a clip to length < 1

M  +4    -0    src/timeline2/model/timelinemodel.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/641c89e8a8bfeabc99f255b2a0a22e683295c8e2

Comment 3 Jean-Baptiste Mardelle 2024-01-29 18:00:58 UTC

Git commit 57721eb6ef4a5772f688757ff80cec1ca8f8bd2f by Jean-Baptiste Mardelle.
Committed on 29/01/2024 at 17:59.
Pushed by mardelle into branch 'release/24.02'.

Fix group move corrupting undo

M  +14   -0    src/timeline2/model/timelinemodel.cpp
M  +3    -0    src/timeline2/model/timelinemodel.hpp
M  +5    -5    src/timeline2/view/qml/Clip.qml
M  +33   -10   src/timeline2/view/qml/SubTitle.qml
M  +2    -2    src/timeline2/view/qml/Track.qml

https://invent.kde.org/multimedia/kdenlive/-/commit/57721eb6ef4a5772f688757ff80cec1ca8f8bd2f